SampleUses added for CombinatorialRandomAttribute

Author: AlexRadch

src/Xunit.Combinatorial.Tests/CombinatorialRandomAttributeTests.cs

@@ -35,28 +35,29 @@ public void ConstructorCountMinMaxValues(int count, int minValue, int maxValue)
         [InlineData(1, 25, 35, 234)]
         [InlineData(3, 100, 200, 1343)]
         [InlineData(24, 1000, 3000, 56732)]
+        [InlineData(12, 576, 765, CombinatorialRandomAttribute.NoSeed)]
         public void ConstructorCountMinMaxValuesSeed(int count, int minValue, int maxValue, int seed)
             => Check(new CombinatorialRandomAttribute(count, minValue, maxValue, seed), count, minValue, maxValue, seed);
 
         [Theory]
         [InlineData(0)]
         [InlineData(-1)]
         [InlineData(int.MinValue)]
-        public void ConstructorNegativeCount(int count)
+        public void ConstructorOutOfRangeCount(int count)
         {
             Assert.Throws<ArgumentOutOfRangeException>(() => new CombinatorialRandomAttribute(count));
             Assert.Throws<ArgumentOutOfRangeException>(() => new CombinatorialRandomAttribute(count, 100));
             Assert.Throws<ArgumentOutOfRangeException>(() => new CombinatorialRandomAttribute(count, 0, 100));
-            Assert.Throws<ArgumentOutOfRangeException>(() => new CombinatorialRandomAttribute(count, 0, 100, null));
             Assert.Throws<ArgumentOutOfRangeException>(() => new CombinatorialRandomAttribute(count, 0, 100, 325));
+            Assert.Throws<ArgumentOutOfRangeException>(() => new CombinatorialRandomAttribute(count, 0, 100, CombinatorialRandomAttribute.NoSeed));
         }
 
         internal void Check(
             CombinatorialRandomAttribute attribute, 
             int count = CombinatorialRandomAttribute.DefaultCount,
             int minValue = CombinatorialRandomAttribute.DefaultMinValue,
             int maxValue = CombinatorialRandomAttribute.DefaultMaxValue,
-            int? seed = null)
+            int seed = CombinatorialRandomAttribute.NoSeed)
         {
             Assert.NotNull(attribute.Values);
             Assert.Equal(count, attribute.Values.Length);
@@ -68,9 +69,9 @@ internal void Check(
                 Assert.InRange(intValue, minValue, maxValue - 1);
             });
 
-            if (seed.HasValue)
+            if (seed != CombinatorialRandomAttribute.NoSeed)
             {
-                Assert.Equal(RandomIterator(count, new Random(seed.Value), minValue, maxValue), attribute.Values.Cast<int>());
+                Assert.Equal(RandomIterator(count, new Random(seed), minValue, maxValue), attribute.Values.Cast<int>());
             }
         }
 

src/Xunit.Combinatorial.Tests/SampleUses.cs

@@ -68,6 +68,36 @@ public void CombinatorialCustomRange([CombinatorialRange(0, 5)] int p1, [Combina
             Assert.True(p2 == 0 || p2 == 2);
         }
 
+        [Theory, CombinatorialData]
+        public void CombinatorialRandomValuesDefault([CombinatorialRandom()] int p1)
+        {
+            Assert.InRange(p1, 0, int.MaxValue - 1);
+        }
+
+        [Theory, CombinatorialData]
+        public void CombinatorialRandomValuesCount([CombinatorialRandom(10)] int p1)
+        {
+            Assert.InRange(p1, 0, int.MaxValue - 1);
+        }
+
+        [Theory, CombinatorialData]
+        public void CombinatorialRandomValuesCountMaxValue([CombinatorialRandom(10, 35)] int p1)
+        {
+            Assert.InRange(p1, 0, 35 - 1);
+        }
+
+        [Theory, CombinatorialData]
+        public void CombinatorialRandomValuesCountMinMaxValues([CombinatorialRandom(10, -20, -5)] int p1)
+        {
+            Assert.InRange(p1, -20, -5 - 1);
+        }
+
+        [Theory, CombinatorialData]
+        public void CombinatorialRandomValuesCountMinMaxValuesSeed([CombinatorialRandom(10, -5, 6, 567)] int p1)
+        {
+            Assert.InRange(p1, -5, 6 - 1);
+        }
+
         [AttributeUsage(AttributeTargets.Parameter)]
         private class CustomValuesAttribute : CombinatorialValuesAttribute
         {

src/Xunit.Combinatorial/CombinatorialRandomAttribute.cs

@@ -25,11 +25,16 @@ public class CombinatorialRandomAttribute : Attribute
         /// </summary>
         public const int DefaultMaxValue = int.MaxValue;
 
+        /// <summary>
+        /// Special seed value to create System.Random class without seed.
+        /// </summary>
+        public const int NoSeed = int.MinValue;
+
         /// <summary>
         /// Initializes a new instance of the <see cref="CombinatorialRandomAttribute"/> class.
         /// </summary>
         public CombinatorialRandomAttribute()
-            : this(DefaultCount, DefaultMinValue, DefaultMaxValue, null)
+            : this(DefaultCount, DefaultMinValue, DefaultMaxValue, NoSeed)
         {
         }
 
@@ -41,7 +46,7 @@ public CombinatorialRandomAttribute()
         /// Cannot be less than 1, which would conceptually result in zero test cases.
         /// </param>
         public CombinatorialRandomAttribute(int count)
-            : this(count, DefaultMinValue, DefaultMaxValue, null)
+            : this(count, DefaultMinValue, DefaultMaxValue, NoSeed)
         {
         }
 
@@ -56,7 +61,7 @@ public CombinatorialRandomAttribute(int count)
         /// maxValue for System.Random.Next method.
         /// </param>
         public CombinatorialRandomAttribute(int count, int maxValue)
-            : this(count, DefaultMinValue, maxValue, null)
+            : this(count, DefaultMinValue, maxValue, NoSeed)
         {
         }
 
@@ -74,7 +79,7 @@ public CombinatorialRandomAttribute(int count, int maxValue)
         /// maxValue for System.Random.Next method.
         /// </param>
         public CombinatorialRandomAttribute(int count, int minValue, int maxValue)
-            : this(count, minValue, maxValue, null)
+            : this(count, minValue, maxValue, NoSeed)
         {
         }
 
@@ -92,16 +97,16 @@ public CombinatorialRandomAttribute(int count, int minValue, int maxValue)
         /// maxValue for System.Random.Next method.
         /// </param>
         /// <param name="seed">
-        /// seed for System.Random constructor.
+        /// Seed for System.Random constructor. If Seed equal to NoSeed value then System.Random constructor whithout seed used.
         /// </param>
-        public CombinatorialRandomAttribute(int count, int minValue, int maxValue, int? seed)
+        public CombinatorialRandomAttribute(int count, int minValue, int maxValue, int seed)
         {
             if (count < 1)
             {
                 throw new ArgumentOutOfRangeException(nameof(count));
             }
 
-            var random = seed.HasValue ? new Random(seed.Value) : new Random();
+            var random = seed == NoSeed ? new Random() : new Random(seed);
 
             object[] values = new object[count];
             for (int i = 0; i < count; i++)