Skip to content

Commit 81af268

Browse files
Merge branch 'topic/fix_edge_build' into 'master'
Avoid overriding LSP_Uri '=' operator as abstract See merge request eng/ide/ada_language_server!2086
2 parents 9dba4f8 + 63a5adc commit 81af268

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

liblsp_3_16/source/lsp-types.ads

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -294,15 +294,16 @@ package LSP.Types is
294294
subtype ProgressToken is LSP_Number_Or_String;
295295

296296
type LSP_URI is private;
297+
-- Type for LSP URI.
298+
--
299+
-- Note that URIs can be different while pointing to the same file. So
300+
-- when wanting to determine if two URIs represent the same file, avoid
301+
-- comparing them with "=". Instead, the URIs should be converted to
302+
-- normalized paths before comparison (e.g. with GNATCOLL.VFS).
297303

298304
function Equal (Left, Right : LSP_URI) return Boolean;
299305
-- Let's try to avoid URI comparison.
300306

301-
overriding function "=" (Left, Right : LSP_URI) return Boolean is abstract;
302-
-- Disable URI comparison with "=". Two URIs can point the same file
303-
-- even when they are distinct. In most case we shouldn't compare URIs,
304-
-- but find corresponding files and compare their normalized names.
305-
306307
function File_To_URI (File : String) return LSP.Types.LSP_URI;
307308
-- Turn the File name into an URI
308309

0 commit comments

Comments
 (0)