Skip to content

Commit 747a4a4

Browse files
refactor code (#40)
1 parent 68c4e0e commit 747a4a4

File tree

1 file changed

+15
-11
lines changed

1 file changed

+15
-11
lines changed

src/Devices.js

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,20 @@ export function findUserSpecifiesDevices(userSpecifiedUDIDS, availableDevices) {
9595
return filteredDevices;
9696
}
9797

98+
function fetchDevicesFromUDIDS(simulators, connectedAndroidDevices, connectedIOSDevices) {
99+
const userSpecifiedUDIDS = process.env.UDIDS.split(',');
100+
const availableDevices = Object.assign(
101+
simulators,
102+
connectedAndroidDevices,
103+
connectedIOSDevices
104+
);
105+
const filteredDevices = findUserSpecifiesDevices(
106+
userSpecifiedUDIDS,
107+
availableDevices
108+
);
109+
return new Devices(filteredDevices);
110+
}
111+
98112
export async function fetchDevices() {
99113
const udids = process.env.UDIDS;
100114
if (instance === false) {
@@ -109,17 +123,7 @@ export async function fetchDevices() {
109123
connectedIOSDevices = await iosDevices.getDevices();
110124
connectedAndroidDevices = await androidDevices.getDevices();
111125
if (udids) {
112-
const userSpecifiedUDIDS = process.env.UDIDS.split(',');
113-
const availableDevices = Object.assign(
114-
simulators,
115-
connectedAndroidDevices,
116-
connectedIOSDevices
117-
);
118-
const filteredDevices = findUserSpecifiesDevices(
119-
userSpecifiedUDIDS,
120-
availableDevices
121-
);
122-
devices = new Devices(filteredDevices);
126+
devices = fetchDevicesFromUDIDS(simulators, connectedAndroidDevices, connectedIOSDevices);
123127
} else {
124128
devices = new Devices(
125129
Object.assign(

0 commit comments

Comments
 (0)