Revise network settings for ADSL and LAN settin

[nitomartinez]

The settings in nxcomp are setup for:

• ADSL. 256kbps. Current standard is at least 1Mbps (lowest end throughout the world), and usually more than 3Mbps
• LAN. 10/100 Mbps. Usually nowadays it is used 1Gbps

Items to solve:

• Update the current speed settings.
• This probably needs to have the same changes in the server and in the client. That is a change in the settings in the client, needs to have the same settings in the server (Best Guess).

Transition options:

• Create new speed settings (See SetLink function in Loop.cpp),
• Make it dependant on versioning. See if some special care needs to be taken if different settings (See SetVersion in Loop.cpp)

Example bit to be changed. In Loop.cpp we get:

//
// Parameters for ADSL 256 Kbps.
//

int SetLinkAdsl()
{
  #ifdef TEST
  *logofs << "Loop: Setting parameters for ADSL.\n"
          << logofs_flush;
  #endif

  control -> LinkMode = LINK_TYPE_ADSL;

  control -> TokenSize  = 512;
  control -> TokenLimit = 24;

  control -> SplitMode             = 1;
  control -> SplitTotalSize        = 128;
  control -> SplitTotalStorageSize = 1048576;

  control -> SplitTimeout   = 50;
  control -> MotionTimeout  = 10;
  control -> IdleTimeout    = 50;

  control -> PackMethod  = PACK_ADAPTIVE;
  control -> PackQuality = 7;

  return 1;
}

[nitomartinez]

Positive tests have been made by using type=ADSL and increasing bandwidth limit to 10m via NX option limit.

Example:

limit=10m

/usr/lib/nx/bin/nxproxy limit=10m -S media=4713 cups=631 slave=62253 localhost:40

[sunweaver]

@nitomartinez: Thanks for testing this. Are you planning to come up with a concrete patch for changing this? Or shall someone else handle this enhancement request?

[nitomartinez]

Hi Mike,

I am currently working on something else, and the workaround is working for me :-P

If you can get someone else on this, it would be great, if not I pick it up later on.

[uli42]

How do you define if a setting is "better" than another setting?

I think for compatibility these settings should stay as they are. People relying on them might stumble over that change. Why not introduce adsl1M and lan1Gb or similar?

Best solution would be a mechanism that auto-adjusts according to the current line properties.

[nitomartinez]

Agreed that auto adjustment would be nice.

Just raised the point of something to review.

Adding to your point, latency is the other factor which is different between the ADSL and LAN settings (well right now in the 3.5.x series)

[nitomartinez]

Some more info:

The bandwidth checks are done (at least in this place, not sure if there are others) in the 3.5 branch in the function handleCheckBitrateInLoop in Loop.cpp. There could be pauses up to 435ms (~ 50000 ^ 1.2)

Here is an example of playing an mp3 file, through the NX audio channel .

And here a similar one, with the NX option: limit=0

Please note that audio usage is interesting in itself (which is outside of this issue), in the sense that an mp3 without pulseaudio compression generates 1.2 Mbit of bandwidth.

My two cents.