Merge pull request #187 from Avanade/185-code-improvements

185 code improvements

Author: jerricotandelacruz

src/goapp/controller/item/item-page-controller.go

@@ -238,7 +238,7 @@ func (c *itemPageController) RespondToItem(w http.ResponseWriter, r *http.Reques
 		Data:                *item,
 		RequireRemarks:      itemIsAuthorized.RequireRemarks,
 		IsApprover:          isApprover, // show remarks and approve/reject buttons
-		AlreadyProcessed:    itemIsAuthorized.IsApproved.Value,
+		AlreadyProcessed:    item.DateResponded != "",
 		ApproverResponse:    approverResponse,
 		ConsultLegalButton:  consultLegalButton,
 		Action:              action,

src/goapp/repository/ipdrequest/ipdrequest-repository.go

@@ -106,7 +106,6 @@ func (r *ipdRequestRepository) UpdateResponse(data *model.ResponseCallback) erro
 		sql.Named("ApprovalRequestId", data.ItemId),
 		sql.Named("IsApproved", data.IsApproved),
 		sql.Named("ApproverRemarks", data.Remarks),
-		sql.Named("ResponseDate", data.ResponseDate),
 		sql.Named("RespondedBy", data.RespondedBy),
 	)
 

src/goapp/service/email/email-service.go

@@ -72,7 +72,7 @@ func (s *sdkEmailService) SendActivityEmail(req *model.ItemActivity, recipients
 						<tr>
 							<td style="padding: 15px 0 10px 0;">
 								<span><b>|User|</b></span> 
-								<span>commented on your request:</span>
+								<span>commented on a request:</span>
 							</td>
 						</tr>
 						<tr>

src/sqldb/Stored Procedures/PR_IPDisclosureRequest_Update_Response.sql

@@ -2,15 +2,14 @@ CREATE PROCEDURE [dbo].[PR_IPDisclosureRequest_Update_Response]
   @ApprovalRequestId [UNIQUEIDENTIFIER],
   @IsApproved [BIT],
   @ApproverRemarks [VARCHAR](100),
-  @ResponseDate [DATETIME],
   @RespondedBy [VARCHAR](100)
 AS
 BEGIN
   UPDATE [dbo].[IPDisclosureRequest]
   SET
     [IsApproved] = @IsApproved,
     [ApproverRemarks] = @ApproverRemarks,
-    [ResponseDate] = @ResponseDate,
+    [ResponseDate] = GETDATE(),
     [RespondedBy] = @RespondedBy
   WHERE [ApprovalRequestId] = @ApprovalRequestId
 END