Skip to content

Commit eb48135

Browse files
Copilottheunrepentantgeekmatthchr
authored
Enable ConfigMap support for IPRule.Value (#4839)
* Initial plan * Enable ConfigMap support for IPRule.Value and PublicIPPrefix export Co-authored-by: theunrepentantgeek <1272094+theunrepentantgeek@users.noreply.github.com> * Remove $generatedConfigs for PublicIPPrefix in favor of CEL expressions Co-authored-by: matthchr <8798850+matthchr@users.noreply.github.com> * Remove aso-gen binary and regenerate all types and CRDs - Removed aso-gen binary file that should not be committed - Added aso-gen binary to .gitignore to prevent future commits - Regenerated all Go types with ConfigMap support for IPRule.Value - Regenerated all CRDs and deepcopy files - All storage API versions (2021-04-01, 2022-09-01, 2023-01-01) now support ConfigMap imports for IPRule.Value Co-authored-by: matthchr <8798850+matthchr@users.noreply.github.com> * Remove config/crd/bases directory - these are build artifacts that shouldn't be committed Co-authored-by: theunrepentantgeek <1272094+theunrepentantgeek@users.noreply.github.com> * Regenerate deepcopy files to fix CI verify-no-changes Co-authored-by: theunrepentantgeek <1272094+theunrepentantgeek@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: theunrepentantgeek <1272094+theunrepentantgeek@users.noreply.github.com> Co-authored-by: matthchr <8798850+matthchr@users.noreply.github.com>
1 parent fe6a247 commit eb48135

27 files changed

+272
-31
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,3 +83,4 @@ hack/tools
8383
.go-version
8484
v2/controller
8585
v2/cmd/asoctl/asoctl
86+
v2/tools/generator/aso-gen

v2/api/storage/v1api20210401/arm/storage_account_spec_types_gen.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

v2/api/storage/v1api20210401/storage/storage_account_types_gen.go

Lines changed: 20 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

v2/api/storage/v1api20210401/storage/structure.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,11 @@ StorageAccount: Resource
8080
│ ├── NetworkAcls: *Object (6 properties)
8181
│ │ ├── Bypass: *string
8282
│ │ ├── DefaultAction: *string
83-
│ │ ├── IpRules: Object (3 properties)[]
83+
│ │ ├── IpRules: Object (4 properties)[]
8484
│ │ │ ├── Action: *string
8585
│ │ │ ├── PropertyBag: genruntime.PropertyBag
86-
│ │ │ └── Value: *string
86+
│ │ │ ├── Value: *string
87+
│ │ │ └── ValueFromConfig: *genruntime.ConfigMapReference
8788
│ │ ├── PropertyBag: genruntime.PropertyBag
8889
│ │ ├── ResourceAccessRules: Object (3 properties)[]
8990
│ │ │ ├── PropertyBag: genruntime.PropertyBag

v2/api/storage/v1api20210401/storage/zz_generated.deepcopy.go

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

v2/api/storage/v1api20210401/storage_account_types_gen.go

Lines changed: 30 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

v2/api/storage/v1api20210401/structure.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,10 +104,11 @@ StorageAccount: Resource
104104
│ │ ├── DefaultAction: *Enum (2 values)
105105
│ │ │ ├── "Allow"
106106
│ │ │ └── "Deny"
107-
│ │ ├── IpRules: Object (2 properties)[]
107+
│ │ ├── IpRules: Object (3 properties)[]
108108
│ │ │ ├── Action: *Enum (1 value)
109109
│ │ │ │ └── "Allow"
110-
│ │ │ └── Value: *string
110+
│ │ │ ├── Value: *string
111+
│ │ │ └── ValueFromConfig: *genruntime.ConfigMapReference
111112
│ │ ├── ResourceAccessRules: Object (2 properties)[]
112113
│ │ │ ├── ResourceReference: *genruntime.ResourceReference
113114
│ │ │ └── TenantId: *string

v2/api/storage/v1api20210401/webhook/storage_account_types_gen.go

Lines changed: 13 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

v2/api/storage/v1api20210401/zz_generated.deepcopy.go

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

v2/api/storage/v1api20220901/arm/storage_account_spec_types_gen.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)