fix: adjusting keys to prevent breaking change

Author: tobiasehlert

locals.firewall.tf

@@ -30,7 +30,7 @@ locals {
     for pair in flatten([
       for vnet_name, vnet in var.hub_virtual_networks : [
         for i in range(vnet.firewall.public_ip_count) : {
-          key       = "${vnet_name}-${i}"
+          key       = "${vnet_name}${i == 0 ? "" : "-${i}"}"
           vnet      = vnet
           index     = i
           vnet_name = vnet_name

main.firewall.tf

@@ -11,7 +11,7 @@ module "hub_firewalls" {
   enable_telemetry    = var.enable_telemetry
   firewall_ip_configuration = concat([{
     name                 = each.value.default_ip_configuration.name
-    public_ip_address_id = module.fw_default_ips["${each.key}-1"].public_ip_id
+    public_ip_address_id = module.fw_default_ips[each.key].public_ip_id
     subnet_id            = module.hub_virtual_network_subnets["${each.key}-${local.firewall_subnet_name}"].resource_id
     }], [
     for i in range(1, each.value.public_ip_count) : {