Start improving dash patters

Author: BobLd

UglyToad.PdfPig.Rendering.Skia.Tests/ExpectedImages/pdfpig_skia/2108.11480_2.png

@@ -401,7 +401,7 @@ public void TestAtScale(string expectedImage, string pdfFile, int pageNumber, in
         public void PdfPigSkiaTest(string expectedImage, string pdfFile, int pageNumber, int scale)
         {
 #if DEBUG
-            throw new System.ArgumentException("PdfPigSkiaTest needs to run in Release mode.");
+            //throw new System.ArgumentException("PdfPigSkiaTest needs to run in Release mode.");
 #endif
 
             expectedImage = Path.Combine("pdfpig_skia", expectedImage);

UglyToad.PdfPig.Rendering.Skia.Tests/ExpectedImages/pdfpig_skia/2108.11480_3.png

@@ -114,7 +114,7 @@ public static SKPathEffect ToSKPathEffect(this LineDashPattern lineDashPattern,
                 return null;
             }
 
-            float scale = lineWidth * oneOver72 / 2; // TODO - Scale is still not correct
+            float scale = 1f / lineWidth; //oneOver72 / 2; // TODO - Scale is still not correct
 
             float phase = lineDashPattern.Phase * scale;
 
@@ -130,14 +130,14 @@ public static SKPathEffect ToSKPathEffect(this LineDashPattern lineDashPattern,
                         float[] pattern = new float[lineDashPattern.Array.Count];
                         for (int i = 0; i < lineDashPattern.Array.Count; i++)
                         {
-                            var v = (float)lineDashPattern.Array[i] * scale;
+                            var v = (float)lineDashPattern.Array[i];
                             if (v == 0)
                             {
-                                pattern[i] = oneOver72;
+                                pattern[i] = scale; // TODO - Need to add tests
                             }
                             else
                             {
-                                pattern[i] = v;
+                                pattern[i] = v * scale;
                             }
                         }