Simplify I/O types. Remove unused/proxy chips and gate. (#74)

* Remove wrapper chips

* remove unused chip

* remove unused gate

* simplify point add io

* simplify point mult io

* simplify to affine io

* simplify to projective io

Author: pmikolajczyk41

crates/shielder-circuits/src/chips/el_gamal.rs

@@ -3,15 +3,8 @@ use macros::embeddable;
 
 use super::{points_add::PointsAddChip, scalar_multiply::ScalarMultiplyChip, sum::SumChip};
 use crate::{
-    chips::{
-        points_add::{PointsAddChipInput, PointsAddChipOutput},
-        scalar_multiply::{ScalarMultiplyChipInput, ScalarMultiplyChipOutput},
-    },
-    consts::FIELD_BITS,
-    curve_arithmetic::GrumpkinPoint,
-    embed::Embed,
-    synthesizer::Synthesizer,
-    AssignedCell,
+    chips::scalar_multiply::ScalarMultiplyChipInput, consts::FIELD_BITS,
+    curve_arithmetic::GrumpkinPoint, embed::Embed, synthesizer::Synthesizer, AssignedCell,
 };
 
 #[derive(Clone, Debug)]
@@ -97,33 +90,25 @@ impl ElGamalEncryptionChip {
 
         self.constrain_generator(synthesizer, generator.clone())?;
 
-        let ScalarMultiplyChipOutput {
-            result: shared_secret,
-        } = self.multiply_chip.scalar_multiply(
+        let shared_secret = self.multiply_chip.scalar_multiply(
             synthesizer,
             &ScalarMultiplyChipInput {
                 input: public_key.clone(),
                 scalar_bits: salt_le_bits.clone(),
             },
         )?;
 
-        let ScalarMultiplyChipOutput {
-            result: ciphertext1,
-        } = self.multiply_chip.scalar_multiply(
+        let ciphertext1 = self.multiply_chip.scalar_multiply(
             synthesizer,
             &ScalarMultiplyChipInput {
                 input: generator,
                 scalar_bits: salt_le_bits.clone(),
             },
         )?;
 
-        let PointsAddChipOutput { s: ciphertext2 } = self.add_chip.points_add(
-            synthesizer,
-            &PointsAddChipInput {
-                p: message.clone(),
-                q: shared_secret,
-            },
-        )?;
+        let ciphertext2 = self
+            .add_chip
+            .points_add(synthesizer, message, &shared_secret)?;
 
         Ok(ElGamalEncryptionChipOutput {
             ciphertext1,

crates/shielder-circuits/src/chips/is_point_on_curve.rs

@@ -1,10 +1,7 @@
 pub mod el_gamal;
 pub mod id_hiding;
-pub mod is_point_on_curve;
-pub mod is_point_on_curve_affine;
 pub mod mac;
 pub mod note;
-pub mod point_double;
 pub mod points_add;
 pub mod range_check;
 pub mod scalar_multiply;