Skip to content

Commit 180455b

Browse files
committed
Fix for #441
1 parent ae2b9ce commit 180455b

File tree

1 file changed

+20
-2
lines changed

1 file changed

+20
-2
lines changed

plugins/module_utils/fabric/verify_playbook_params.py

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,6 +238,13 @@ def eval_parameter_rule(self, rule) -> bool:
238238
msg += f"'value' not found in parameter {parameter} rule: {rule}"
239239
raise KeyError(msg)
240240

241+
# Ensure consistent type conversion for rule_value
242+
rule_value = self.conversion.make_none(
243+
self.conversion.make_int(
244+
self.conversion.make_boolean(rule_value)
245+
)
246+
)
247+
241248
msg = f"{self.class_name}.{method_name}: "
242249
msg += f"parameter: {parameter}, "
243250
msg += f"user_value: {user_value}, "
@@ -323,7 +330,9 @@ def controller_param_is_valid(self, item) -> bool:
323330
return None
324331

325332
controller_value = self.conversion.make_none(
326-
self.conversion.make_boolean(self.config_controller[rule_parameter])
333+
self.conversion.make_int(
334+
self.conversion.make_boolean(self.config_controller[rule_parameter])
335+
)
327336
)
328337

329338
msg = f"{self.class_name}.{method_name}: "
@@ -379,7 +388,9 @@ def playbook_param_is_valid(self, item) -> bool:
379388
return None
380389

381390
playbook_value = self.conversion.make_none(
382-
self.conversion.make_boolean(self.config_playbook[rule_parameter])
391+
self.conversion.make_int(
392+
self.conversion.make_boolean(self.config_playbook[rule_parameter])
393+
)
383394
)
384395

385396
msg = f"{self.class_name}.{method_name}: "
@@ -443,6 +454,13 @@ def default_param_is_valid(self, item) -> bool:
443454
self.log.debug(msg)
444455
return None
445456

457+
# Convert default value to ensure consistent type handling
458+
default_value = self.conversion.make_none(
459+
self.conversion.make_int(
460+
self.conversion.make_boolean(default_value)
461+
)
462+
)
463+
446464
# update item with user's parameter value
447465
item["user_value"] = default_value
448466

0 commit comments

Comments
 (0)