corrected the sorting by key as requested by module maintainers

Author: mkilar123

plugins/module_utils/fabric/fabric_types.py

@@ -73,22 +73,22 @@ def _init_fabric_types(self) -> None:
             - Value is a list of mandatory parameters for the fabric type
         """
         self._fabric_type_to_template_name_map = {}
+        self._fabric_type_to_template_name_map["BGP"] = "Easy_Fabric_eBGP"
         self._fabric_type_to_template_name_map["IPFM"] = "Easy_Fabric_IPFM"
         self._fabric_type_to_template_name_map["ISN"] = "External_Fabric"
         self._fabric_type_to_template_name_map["LAN_CLASSIC"] = "LAN_Classic"
         self._fabric_type_to_template_name_map["VXLAN_EVPN"] = "Easy_Fabric"
         self._fabric_type_to_template_name_map["VXLAN_EVPN_MSD"] = "MSD_Fabric"
-        self._fabric_type_to_template_name_map["BGP"] = "Easy_Fabric_eBGP"
 
         # Map fabric type to the feature name that must be running
         # on the controller to enable the fabric type.
         self._fabric_type_to_feature_name_map = {}
+        self._fabric_type_to_feature_name_map["BGP"] = "vxlan"
         self._fabric_type_to_feature_name_map["IPFM"] = "pmn"
         self._fabric_type_to_feature_name_map["ISN"] = "vxlan"
         self._fabric_type_to_feature_name_map["LAN_CLASSIC"] = "lan"
         self._fabric_type_to_feature_name_map["VXLAN_EVPN"] = "vxlan"
         self._fabric_type_to_feature_name_map["VXLAN_EVPN_MSD"] = "vxlan"
-        self._fabric_type_to_feature_name_map["BGP"] = "vxlan"
 
         # Map fabric type to the value that the controller GUI displays
         # in the Fabric Type column at NDFC -> Manage -> Fabrics
@@ -117,6 +117,9 @@ def _init_fabric_types(self) -> None:
         self._mandatory_parameters_all_fabrics.append("FABRIC_TYPE")
 
         self._mandatory_parameters = {}
+        self._mandatory_parameters["BGP"] = copy.copy(
+            self._mandatory_parameters_all_fabrics
+        )
         self._mandatory_parameters["IPFM"] = copy.copy(
             self._mandatory_parameters_all_fabrics
         )
@@ -129,22 +132,19 @@ def _init_fabric_types(self) -> None:
         self._mandatory_parameters["VXLAN_EVPN"] = copy.copy(
             self._mandatory_parameters_all_fabrics
         )
-        self._mandatory_parameters["BGP"] = copy.copy(
-            self._mandatory_parameters_all_fabrics
-        )
+        self._mandatory_parameters["BGP"].append("BGP_AS")
         self._mandatory_parameters["ISN"].append("BGP_AS")
         self._mandatory_parameters["VXLAN_EVPN"].append("BGP_AS")
-        self._mandatory_parameters["BGP"].append("BGP_AS")
         self._mandatory_parameters["VXLAN_EVPN_MSD"] = copy.copy(
             self._mandatory_parameters_all_fabrics
         )
 
+        self._mandatory_parameters["BGP"].sort()
         self._mandatory_parameters["IPFM"].sort()
         self._mandatory_parameters["ISN"].sort()
         self._mandatory_parameters["LAN_CLASSIC"].sort()
         self._mandatory_parameters["VXLAN_EVPN"].sort()
         self._mandatory_parameters["VXLAN_EVPN_MSD"].sort()
-        self._mandatory_parameters["BGP"].sort()
 
     def _init_properties(self) -> None:
         """

plugins/modules/dcnm_fabric.py

@@ -61,12 +61,12 @@
                 type: str
             FABRIC_TYPE:
                 choices:
+                - BGP
                 - IPFM
                 - ISN
                 - LAN_CLASSIC
                 - VXLAN_EVPN
                 - VXLAN_EVPN_MSD
-                - BGP
                 description:
                 - The type of fabric.
                 required: true