Fix for Issue #428 "dcnm_fabric returns incorrect results when querying invalid fabrics on NDFC" (#429)

* Fix for Issue #428 "dcnm_fabric returns incorrect results when querying invalid fabrics on NDFC

* Fix Test Fabric Query Unit Tests - 0030 and 0031

* "Fix Assertion Cases for DCNM Test Fabric Query Unit TC 00030, 00031"

---------

Co-authored-by: = <=>

Author: AKDRG

plugins/module_utils/fabric/query.py

@@ -219,4 +219,14 @@ def commit(self):
         self.results.result_current = copy.deepcopy(
             self.fabric_details.results.result_current
         )
+
+        if not add_to_diff:
+            msg = f"No fabric details found for {self.fabric_names}."
+            self.log.debug(msg)
+            self.results.result_current["found"] = False
+            self.results.result_current["success"] = False
+        else:
+            msg = f"Found fabric details for {self.fabric_names}."
+            self.log.debug(msg)
+
         self.results.register_task_result()

tests/unit/modules/dcnm/dcnm_fabric/test_fabric_query.py

@@ -410,11 +410,11 @@ def responses():
 
     assert instance.results.diff[0].get("sequence_number", None) == 1
     assert instance.results.response[0].get("RETURN_CODE", None) == 200
-    assert instance.results.result[0].get("found", None) is True
-    assert instance.results.result[0].get("success", None) is True
+    assert instance.results.result[0].get("found", None) is False
+    assert instance.results.result[0].get("success", None) is False
 
-    assert False in instance.results.failed
-    assert True not in instance.results.failed
+    assert True in instance.results.failed
+    assert False not in instance.results.failed
     assert False in instance.results.changed
     assert True not in instance.results.changed
 
@@ -519,11 +519,11 @@ def responses():
 
     assert instance.results.diff[0].get("sequence_number", None) == 1
     assert instance.results.response[0].get("RETURN_CODE", None) == 200
-    assert instance.results.result[0].get("found", None) is True
-    assert instance.results.result[0].get("success", None) is True
+    assert instance.results.result[0].get("found", None) is False
+    assert instance.results.result[0].get("success", None) is False
 
-    assert False in instance.results.failed
-    assert True not in instance.results.failed
+    assert True in instance.results.failed
+    assert False not in instance.results.failed
     assert False in instance.results.changed
     assert True not in instance.results.changed