add route_tag for subinterface (#415)

* add route_tag for subinterface

* fix pep issue and add sanity tests

* add route_tag in the documentation

* Update dcnm_intf_multi_intf_configs.json

* Update dcnm_intf_multi_intf_payloads.json

* Update dcnm_intf_subint_payloads.json

* Update dcnm_intf_multi_intf_configs.json

Author: ccoueffe

plugins/modules/dcnm_interface.py

@@ -377,6 +377,11 @@
             - Administrative state of the interface
             type: bool
             default: true
+          route_tag:
+            description:
+            - Route tag associated with the interface IP.
+            type: str
+            default: ""
       profile_lo:
         description:
         - Though the key shown here is 'profile_lo' the actual key to be used in playbook
@@ -2385,6 +2390,7 @@ def dcnm_intf_validate_sub_interface_input(self, cfg):
                 type="int", range_min=64, range_max=127, default=64
             ),
             mtu=dict(type="int", range_min=576, range_max=9216, default=9216),
+            route_tag=dict(type="str", default=""),
             speed=dict(type="str", default="Auto"),
             cmds=dict(type="list", elements="str"),
             description=dict(type="str", default=""),
@@ -3068,6 +3074,9 @@ def dcnm_intf_get_sub_intf_payload(self, delem, intf, profile):
         intf["interfaces"][0]["nvPairs"]["PREFIX"] = str(
             delem[profile]["ipv4_mask_len"]
         )
+        intf["interfaces"][0]["nvPairs"]["ROUTING_TAG"] = delem[profile][
+            "route_tag"
+        ]
         if delem[profile]["ipv6_addr"]:
             intf["interfaces"][0]["nvPairs"]["IPv6"] = str(
                 delem[profile]["ipv6_addr"]

tests/unit/modules/dcnm/fixtures/dcnm_intf_multi_intf_configs.json

@@ -95,10 +95,10 @@
         "policy": "int_port_channel_trunk_host_11_1",
         "admin_state": "True",
         "allowed_vlans": "none",
-	      "native_vlan": "10",
+	"native_vlan": "10",
         "orphan_port": false,
-	      "speed": "Auto",
-	      "duplex": "auto",
+	"speed": "Auto",
+	"duplex": "auto",
         "cmds": [
           "no shutdown"
         ],
@@ -198,6 +198,7 @@
         "mode": "subint",
         "policy": "int_subif_11_1",
         "admin_state": "True",
+        "route_tag": "",
         "ifname": "Ethernet1/1.1",
         "cmds": [
           "no shutdown"
@@ -249,10 +250,10 @@
         "policy": "int_port_channel_trunk_host_11_1",
         "admin_state": "True",
         "allowed_vlans": "none",
-	      "native_vlan": "10",
+	"native_vlan": "10",
         "orphan_port": false,
-	      "speed": "Auto",
-	      "duplex": "auto",
+	"speed": "Auto",
+	"duplex": "auto",
         "cmds": [
           "spanning-tree bpduguard enable"
         ],

tests/unit/modules/dcnm/fixtures/dcnm_intf_multi_intf_payloads.json

@@ -178,6 +178,7 @@
             "PREFIX": "24",
             "IPv6": "",
             "IPv6_PREFIX": "",
+            "ROUTING_TAG": "",
             "MTU": "9216",
             "INTF_NAME": "Ethernet1/1.1",
             "DESC": "sub interface eth25/1.1 configuration",

tests/unit/modules/dcnm/fixtures/dcnm_intf_subint_configs.json

@@ -41,7 +41,7 @@
 
 	"mock_ip_sn" : {
 		"192.168.1.109": "FOX1821H035",
-			"192.168.1.108": "SAL1819SAN8" 
+			"192.168.1.108": "SAL1819SAN8"
 	},
 
 		"mock_vpc_sno" : {
@@ -97,6 +97,7 @@
 				"policy": "int_subif_11_1",
 				"admin_state": "True",
 				"ifname": "Ethernet1/25.1",
+				"route_tag": 12345,
 				"cmds": [
 					"no shutdown"
 				],
@@ -124,6 +125,7 @@
 				"policy": "int_subif_11_1",
 				"admin_state": "True",
 				"ifname": "Ethernet1/25.2",
+				"route_tag": 12345,
 				"cmds": [
 					"no shutdown"
 				],
@@ -153,6 +155,7 @@
 				"policy": "int_subif_11_1",
 				"admin_state": "False",
 				"ifname": "Ethernet1/27.1",
+				"route_tag": 12345,
 				"cmds": [
 					"no shutdown",
 					"no shutdown"
@@ -183,6 +186,7 @@
 				"policy": "int_subif_11_1",
 				"admin_state": "False",
 				"ifname": "Ethernet1/25.1",
+				"route_tag": 12345,
 				"cmds": [
 					"no shutdown",
 					"no shutdown"
@@ -211,6 +215,7 @@
 				"policy": "int_subif_11_1",
 				"admin_state": "False",
 				"ifname": "Ethernet1/25.2",
+				"route_tag": 12345,
 				"cmds": [
 					"no shutdown",
 					"no shutdown"

tests/unit/modules/dcnm/fixtures/dcnm_intf_subint_payloads.json

@@ -17,12 +17,13 @@
 						"IP": "1.1.1.1",
 						"VLAN": "100",
 						"MTU": "9216",
-            "SPEED": "auto",
+            					"SPEED": "auto",
 						"PRIORITY": "500",
 						"PREFIX": "24",
 						"ADMIN_STATE": "True",
 						"POLICY_DESC": "",
 						"INTF_NAME": "Ethernet1/25.1",
+						"ROUTING_TAG": "12345",
 						"IPv6": "",
 						"IPv6_PREFIX": "",
 						"DESC": "sub interface eth25/1.1 configuration",
@@ -52,12 +53,13 @@
 						"IP": "1.1.1.2",
 						"VLAN": "101",
 						"MTU": "9216",
-            "SPEED": "auto",
+            					"SPEED": "auto",
 						"PRIORITY": "500",
 						"PREFIX": "24",
 						"ADMIN_STATE": "True",
 						"POLICY_DESC": "",
 						"INTF_NAME": "Ethernet1/25.2",
+						"ROUTING_TAG": "12345",
 						"IPv6": "",
 						"IPv6_PREFIX": "",
 						"DESC": "sub interface eth1/25.2 configuration",