Experimental fix for 500 controller response

The field serializer for extension_values in PayloadVrfsAttachmentsLanAttachListItem needs to set the value to “” if MULTISOTE_CONN and VRF_LITE_CONN both have zero length, else the controller chokes on the payload.

This commit tests one way to accomplish this.  If this works against the contoller, I’ll clean things up in the next commit.

Author: allenrobel

plugins/module_utils/vrf/model_payload_vrfs_attachments.py

@@ -395,7 +395,10 @@ def serialize_extension_values(self, value: PayloadVrfsAttachmentsLanAttachListE
         Serialize extension_values to a JSON string.
         """
         if value == "":
-            return json.dumps({})  # return empty JSON value
+            return ""
+            # return json.dumps({})  # return empty JSON value
+        if len(value.MULTISITE_CONN.MULTISITE_CONN) == 0 and len(value.VRF_LITE_CONN.VRF_LITE_CONN) == 0:
+            return ""
         return value.model_dump_json(by_alias=True)
 
     @field_serializer("instance_values")

plugins/module_utils/vrf/transmute_diff_attach_to_payload.py

@@ -174,8 +174,14 @@ def commit(self) -> None:
 
         payload_model: list[PayloadVrfsAttachments] = []
         for vrf_attach_payload in diff_attach_list:
-            new_lan_attach_list = self.update_lan_attach_list_model(vrf_attach_payload)
-            vrf_attach_payload.lan_attach_list = new_lan_attach_list
+            lan_attach_list = self.update_lan_attach_list_model(vrf_attach_payload)
+            msg = f"ZZZ: lan_attach_list: {lan_attach_list}"
+            self.log.debug(msg)
+            # for item in lan_attach_list:
+            #     if item.extension_values.VRF_LITE_CONN.VRF_LITE_CONN == [] and item.extension_values.MULTISITE_CONN.MULTISITE_CONN == []:
+            #         item.extension_values = ""
+            vrf_attach_payload.lan_attach_list = lan_attach_list
+            # vrf_attach_payload.lan_attach_list = self.update_lan_attach_list_model(vrf_attach_payload)
             payload_model.append(vrf_attach_payload)
 
         msg = f"Setting payload_model: type(payload_model[0]): {type(payload_model[0])} length: {len(payload_model)}."
@@ -184,6 +190,8 @@ def commit(self) -> None:
 
         self._payload_model = payload_model
         self._payload = json.dumps([model.model_dump(exclude_unset=True, by_alias=True) for model in payload_model])
+        msg = f"Setting payload: {self._payload}"
+        self.log.debug(msg)
 
     def update_lan_attach_list_model(self, diff_attach: PayloadVrfsAttachments) -> list[PayloadVrfsAttachmentsLanAttachListItem]:
         """
@@ -351,19 +359,19 @@ def update_vrf_attach_vrf_lite_extensions(
 
         ## Description
 
-        1.  Merge the values from the vrf_attach object into a matching
-            vrf_lite extension object (if any) from the switch.
+        1.  Merge the values from the vrf_attach object into a matching vrf_lite extension object (if any) from the switch.
         2.  Update the vrf_attach object with the merged result.
         3.  Return the updated vrf_attach object.
 
-        If no matching ControllerResponseVrfsSwitchesExtensionPrototypeValue model is found,
-        return the unmodified vrf_attach object.
+        ## Raises
+
+        - ValueError if:
+          - No matching ControllerResponseVrfsSwitchesExtensionPrototypeValue model is found, return the unmodified vrf_attach object.
 
         "matching" in this case means:
 
         1.  The extensionType of the switch's extension object is VRF_LITE
-        2.  The IF_NAME in the extensionValues of the extension object
-            matches the interface in vrf_attach.extension_values.
+        2.  The IF_NAME in the extensionValues of the extension object matches the interface in vrf_attach.extension_values.
         """
         method_name = inspect.stack()[0][3]
         caller = inspect.stack()[1][3]