fix import and data_source in fabric_l3_handoff_ip_transit

Author: kuba-mazurkiewicz

docs/data-sources/fabric_l3_handoff_ip_transit.md

@@ -14,6 +14,7 @@ This data source can read the Fabric L3 Handoff IP Transit.
 
 ```terraform
 data "catalystcenter_fabric_l3_handoff_ip_transit" "example" {
+  id                = "76d24097-41c4-4558-a4d0-a8c07ac08470"
   network_device_id = "5e6f7b3a-2b0b-4a7d-8b1c-0d4b1cd5e1b1"
   fabric_id         = "c4b85bb2-ce3f-4db9-a32b-e439a388ac2f"
 }
@@ -25,12 +26,12 @@ data "catalystcenter_fabric_l3_handoff_ip_transit" "example" {
 ### Required
 
 - `fabric_id` (String) ID of the fabric this device belongs to
+- `id` (String) The id of the object
 - `network_device_id` (String) Network device ID of the fabric device
 
 ### Read-Only
 
 - `external_connectivity_ip_pool_name` (String) External connectivity ip pool will be used by Catalyst Center to allocate IP address for the connection between the border node and peer
-- `id` (String) The id of the object
 - `interface_name` (String) Interface name of the layer 3 handoff ip transit
 - `local_ip_address` (String) Local ipv4 address for the selected virtual network. Enter the IP addresses and subnet mask in the CIDR notation (IP address/prefix-length). Not applicable if you have already provided an external connectivity ip pool name
 - `local_ipv6_address` (String) Local ipv6 address for the selected virtual network. Enter the IP addresses and subnet mask in the CIDR notation (IP address/prefix-length). Not applicable if you have already provided an external connectivity ip pool name

examples/data-sources/catalystcenter_fabric_l3_handoff_ip_transit/data-source.tf

@@ -1,4 +1,5 @@
 data "catalystcenter_fabric_l3_handoff_ip_transit" "example" {
+  id                = "76d24097-41c4-4558-a4d0-a8c07ac08470"
   network_device_id = "5e6f7b3a-2b0b-4a7d-8b1c-0d4b1cd5e1b1"
   fabric_id         = "c4b85bb2-ce3f-4db9-a32b-e439a388ac2f"
 }

gen/definitions/fabric_l3_handoff_ip_transit.yaml

@@ -6,7 +6,6 @@ id_from_query_path: response
 id_from_query_path_attribute: id
 put_id_include_path: 0.id
 get_from_all: true
-data_source_no_id: true
 put_no_id: true
 doc_category: SDA
 test_tags: [SDA]

internal/provider/data_source_catalystcenter_fabric_l3_handoff_ip_transit.go

@@ -59,7 +59,7 @@ func (d *FabricL3HandoffIPTransitDataSource) Schema(ctx context.Context, req dat
 		Attributes: map[string]schema.Attribute{
 			"id": schema.StringAttribute{
 				MarkdownDescription: "The id of the object",
-				Computed:            true,
+				Required:            true,
 			},
 			"network_device_id": schema.StringAttribute{
 				MarkdownDescription: "Network device ID of the fabric device",

internal/provider/model_catalystcenter_fabric_l3_handoff_ip_transit.go

@@ -110,12 +110,6 @@ func (data FabricL3HandoffIPTransit) toBody(ctx context.Context, state FabricL3H
 
 // Section below is generated&owned by "gen/generator.go". //template:begin fromBody
 func (data *FabricL3HandoffIPTransit) fromBody(ctx context.Context, res gjson.Result) {
-	// Retrieve the 'id' attribute, if Data Source doesn't require id
-	if value := res.Get("response.id"); value.Exists() {
-		data.Id = types.StringValue(value.String())
-	} else {
-		data.Id = types.StringNull()
-	}
 	if value := res.Get("networkDeviceId"); value.Exists() {
 		data.NetworkDeviceId = types.StringValue(value.String())
 	} else {