fmc_vpn_ra test update

Author: rchrabas

gen/definitions/vpn_ra.yaml

@@ -5,6 +5,7 @@ name: VPN RA
 rest_endpoint: /api/fmc_config/v1/domain/{DOMAIN_UUID}/policy/ravpns
 res_description: This resource manages FTD Remote Access (RA) Virtual Private Networks (VPNs).
 doc_category: VPN
+skip_minimum_test: true 
 attributes:
   - model_name: name
     type: String
@@ -28,12 +29,14 @@ attributes:
     description: Enable SSL protocol.
     example: true
     default_value: true
+    minimum_test_value: '"true"'
   - model_name: configureIpsec
     type: Bool
     tf_name: protocol_ipsec_ikev2
     description: Enable IPsec IKEv2 protocol.
     example: true
     default_value: true
+    minimum_test_value: '"true"'
   - model_name: id
     data_path: [localRealmServer]
     type: String
@@ -78,12 +81,14 @@ attributes:
         tf_name: protocol_ipsec_ikev2
         description: Enable IPsec IKEv2.
         example: true
+        minimum_test_value: '"true"'
         #default_value: true
       - model_name: enableSSL
         type: Bool
         tf_name: protocol_ssl
         description: Enable SSL.
         example: true
+        minimum_test_value: '"true"'
         #default_value: true
       - model_name: enableDTLS
         type: Bool
@@ -195,6 +200,7 @@ attributes:
     description: Id of Secure Client Customization.
     type: String
     computed: true
+    exclude_test: true # FMCVERSION <= 7.2
 
   # Advenced - Address Assignment Policy
   # Configuration managed by another endpoint
@@ -245,6 +251,7 @@ attributes:
     type: String
     description: Id of Load Balancing settings.
     computed: true
+    exclude_test: true # FMCVERSION <= 7.2
 
   # Advanced - IPSEC - Crypto Maps
   # Configuration managed by another endpoint

internal/provider/data_source_fmc_vpn_ra_test.go

@@ -42,11 +42,9 @@ func TestAccDataSourceFmcVPNRA(t *testing.T) {
 	checks = append(checks, resource.TestCheckResourceAttr("data.fmc_vpn_ra.test", "web_access_port_number", "443"))
 	checks = append(checks, resource.TestCheckResourceAttr("data.fmc_vpn_ra.test", "dtls_port_number", "443"))
 	checks = append(checks, resource.TestCheckResourceAttr("data.fmc_vpn_ra.test", "bypass_access_control_policy_for_decrypted_traffic", "false"))
-	checks = append(checks, resource.TestCheckResourceAttrSet("data.fmc_vpn_ra.test", "secure_client_customization_id"))
 	checks = append(checks, resource.TestCheckResourceAttrSet("data.fmc_vpn_ra.test", "address_assignment_policy_id"))
 	checks = append(checks, resource.TestCheckResourceAttrSet("data.fmc_vpn_ra.test", "certificate_map_id"))
 	checks = append(checks, resource.TestCheckResourceAttrSet("data.fmc_vpn_ra.test", "ldap_attribute_map_id"))
-	checks = append(checks, resource.TestCheckResourceAttrSet("data.fmc_vpn_ra.test", "load_balancing_id"))
 	checks = append(checks, resource.TestCheckResourceAttrSet("data.fmc_vpn_ra.test", "ipsec_ike_parameters_id"))
 	resource.Test(t, resource.TestCase{
 		PreCheck:                 func() { testAccPreCheck(t) },

internal/provider/resource_fmc_vpn_ra_test.go

@@ -19,7 +19,6 @@ package provider
 
 // Section below is generated&owned by "gen/generator.go". //template:begin imports
 import (
-	"os"
 	"testing"
 
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
@@ -43,19 +42,12 @@ func TestAccFmcVPNRA(t *testing.T) {
 	checks = append(checks, resource.TestCheckResourceAttr("fmc_vpn_ra.test", "web_access_port_number", "443"))
 	checks = append(checks, resource.TestCheckResourceAttr("fmc_vpn_ra.test", "dtls_port_number", "443"))
 	checks = append(checks, resource.TestCheckResourceAttr("fmc_vpn_ra.test", "bypass_access_control_policy_for_decrypted_traffic", "false"))
-	checks = append(checks, resource.TestCheckResourceAttrSet("fmc_vpn_ra.test", "secure_client_customization_id"))
 	checks = append(checks, resource.TestCheckResourceAttrSet("fmc_vpn_ra.test", "address_assignment_policy_id"))
 	checks = append(checks, resource.TestCheckResourceAttrSet("fmc_vpn_ra.test", "certificate_map_id"))
 	checks = append(checks, resource.TestCheckResourceAttrSet("fmc_vpn_ra.test", "ldap_attribute_map_id"))
-	checks = append(checks, resource.TestCheckResourceAttrSet("fmc_vpn_ra.test", "load_balancing_id"))
 	checks = append(checks, resource.TestCheckResourceAttrSet("fmc_vpn_ra.test", "ipsec_ike_parameters_id"))
 
 	var steps []resource.TestStep
-	if os.Getenv("SKIP_MINIMUM_TEST") == "" {
-		steps = append(steps, resource.TestStep{
-			Config: testAccFmcVPNRAPrerequisitesConfig + testAccFmcVPNRAConfig_minimum(),
-		})
-	}
 	steps = append(steps, resource.TestStep{
 		Config: testAccFmcVPNRAPrerequisitesConfig + testAccFmcVPNRAConfig_all(),
 		Check:  resource.ComposeTestCheckFunc(checks...),
@@ -389,20 +381,6 @@ locals {
 // End of section. //template:end testPrerequisites
 
 // Section below is generated&owned by "gen/generator.go". //template:begin testAccConfigMinimal
-
-func testAccFmcVPNRAConfig_minimum() string {
-	config := `resource "fmc_vpn_ra" "test" {` + "\n"
-	config += `	name = "my_ftd_ra_vpn"` + "\n"
-	config += `	access_interfaces = [{` + "\n"
-	config += `		id = fmc_security_zone.test.id` + "\n"
-	config += `	}]` + "\n"
-	config += `	group_policies = [{` + "\n"
-	config += `		id = data.fmc_group_policy.test.id` + "\n"
-	config += `	}]` + "\n"
-	config += `}` + "\n"
-	return config
-}
-
 // End of section. //template:end testAccConfigMinimal
 
 // Section below is generated&owned by "gen/generator.go". //template:begin testAccConfigAll