Fix for Default behavior for ndfc_interface_ethernet resource

Author: akabhask

internal/provider/ndfc/interfaces_eth.go

@@ -49,10 +49,23 @@ func (i *NDFCEthernetInterface) DeleteInterface(ctx context.Context, dg *diag.Di
 		return
 	}
 	intfPayload := resource_interface_common.NDFCInterfacesPayload{}
-	intfPayload.Policy = inData.Policy
 
 	ifDeployPayload := resource_interface_common.NDFCInterfacesDeploy{}
-
+	client := getNDFCClient()
+	resp := client.GetDeviceRole(ctx, dg, inData.SerialNumber)
+	var role string
+	if !resp.Exists() {
+		// Avoiding error if the device role is not found and assuming the role is leaf
+		role = "leaf"
+	} else {
+		role = resp.Array()[0].Get("role").String()
+	}
+	tflog.Debug(ctx, fmt.Sprintf("Device role: %s", role))
+	if role == "leaf" {
+		intfPayload.Policy = "int_trunk_host"
+	} else {
+		intfPayload.Policy = "int_routed_host"
+	}
 	for k, intf := range inData.Interfaces {
 		tflog.Debug(ctx, fmt.Sprintf("Deleting interface: %s:%s", intf.SerialNumber, intf.InterfaceName))
 
@@ -66,13 +79,24 @@ func (i *NDFCEthernetInterface) DeleteInterface(ctx context.Context, dg *diag.Di
 		intf.NvPairs.Netflow = "false"
 		intf.NvPairs.NetflowMonitor = "###"
 		intf.NvPairs.NetflowSampler = "###"
-
-		//Set some default values
-		intf.NvPairs.Speed = "Auto"
-		intf.NvPairs.Mtu = "default"
-		intf.NvPairs.AdminState = "false"
-		intf.NvPairs.AllowedVlans = "none"
-
+		intf.NvPairs.InterfaceName = intf.InterfaceName
+		if role == "leaf" {
+			//Set default values when role is leaf
+			intf.NvPairs.Speed = "Auto"
+			intf.NvPairs.Mtu = "jumbo"
+			intf.NvPairs.FreeformConfig = "no shutdown"
+			intf.NvPairs.AllowedVlans = "none"
+			intf.NvPairs.BpduGuard = "false"
+			intf.NvPairs.PortTypeFast = "true"
+		} else {
+			intf.NvPairs.Speed = "Auto"
+			intf.NvPairs.Mtu = "9216"
+			intf.NvPairs.FreeformConfig = "no shutdown"
+			intf.NvPairs.Vrf = ""
+			intf.NvPairs.Ipv4Address = ""
+			intf.NvPairs.Ipv4PrefixLength = ""
+			intf.NvPairs.RoutingTag = ""
+		}
 		inData.Interfaces[k] = intf
 		intfPayload.Interfaces = append(intfPayload.Interfaces, intf)
 		ifDeployPayload = append(ifDeployPayload, resource_interface_common.NDFCInterfaceDeploy{

internal/provider/ndfc/inventory.go

@@ -140,3 +140,11 @@ func (c NDFC) DeleteFabricInventoryDevices(ctx context.Context, diags *diag.Diag
 		diags.AddError("Delete Devices Failed", err.Error())
 	}
 }
+
+func (c NDFC) GetDeviceRole(ctx context.Context, diags *diag.Diagnostics, serialNum string) gjson.Result {
+	res, err := c.apiClient.Get(fmt.Sprintf("/rest/control/switches/roles?serialNumber=%s", serialNum))
+	if err != nil {
+		diags.AddError("Get Device Role Failed", err.Error())
+	}
+	return res
+}

internal/provider/ndfc/ndfc.go

@@ -114,3 +114,7 @@ func ReleaseResourceLock(rscName string) {
 	instance.deployMutex.RUnlock()
 	log.Printf("+++++++++++++++ReleaseResourceLock for %s+++++++++++pid %d", rscName, os.Getpid())
 }
+
+func getNDFCClient() *NDFC {
+	return instance
+}