Add workaround for issue when concurrently deleting security policies

Author: danischm

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.3.13 (unreleased)
+
+- Add workaround for issue when concurrently deleting security policy objects where the reference count is not updated
+
 ## 0.3.12
 
 - Add `protocol_type` attribute to `sdwan_zone_based_firewall_policy_definition` resource and data source

docs/guides/changelog.md

@@ -7,6 +7,10 @@ description: |-
 
 # Changelog
 
+## 0.3.13 (unreleased)
+
+- Add workaround for issue when concurrently deleting security policy objects where the reference count is not updated
+
 ## 0.3.12
 
 - Add `protocol_type` attribute to `sdwan_zone_based_firewall_policy_definition` resource and data source

gen/definitions/generic/security_policy.yaml

@@ -5,6 +5,7 @@ get_rest_endpoint: /template/policy/security/definition/
 has_version: true
 id_from_query_path: data
 id_from_query_path_attribute: policyId
+delete_mutex: true
 doc_category: Security Policies
 attributes:
   - model_name: policyType

internal/provider/resource_sdwan_security_policy.go

@@ -332,7 +332,9 @@ func (r *SecurityPolicyResource) Delete(ctx context.Context, req resource.Delete
 
 	tflog.Debug(ctx, fmt.Sprintf("%s: Beginning Delete", state.Name.ValueString()))
 
+	r.updateMutex.Lock()
 	res, err := r.client.Delete(state.getPath() + url.QueryEscape(state.Id.ValueString()))
+	r.updateMutex.Unlock()
 	if err != nil {
 		resp.Diagnostics.AddError("Client Error", fmt.Sprintf("Failed to delete object (DELETE), got error: %s, %s", err, res.String()))
 		return

templates/guides/changelog.md.tmpl

@@ -7,6 +7,10 @@ description: |-
 
 # Changelog
 
+## 0.3.13 (unreleased)
+
+- Add workaround for issue when concurrently deleting security policy objects where the reference count is not updated
+
 ## 0.3.12
 
 - Add `protocol_type` attribute to `sdwan_zone_based_firewall_policy_definition` resource and data source