Fix nat being always configured on sdwan_transport_wan_vpn_interface_ethernet_feature (#488)

Author: rchrabas

CHANGELOG.md

@@ -4,6 +4,7 @@
 - BREAKING CHANGE: Rename `sla_class_list` attribute of `sdwan_application_aware_routing_policy_definition` resource to `sla_class_list_id`
 - BREAKING CHANGE: Rename `preferred_color_group_list` attribute of `sdwan_application_aware_routing_policy_definition` resource to `preferred_color_group_list_id`
 - BREAKING CHANGE: Rename `preferred_color_group_list` attribute of `sdwan_traffic_data_policy_definition` resource to `preferred_color_group_list_id`
+- Fix issue, where NAT IPv4 and IPv6 is always configured on `sdwan_transport_wan_vpn_interface_ethernet_feature`, [link](https://github.com/CiscoDevNet/terraform-provider-sdwan/issues/485)
 - Add missing options under `unsupported_features` attribute of `sdwan_configuration_group`, [link](https://github.com/CiscoDevNet/terraform-provider-sdwan/issues/478)
 - Add `sdwan_policy_group` resource and data source
 - Adds `enhanced_app_aware_routing` support to the `sdwan_cisco_system_feature_template` resource and data source

docs/guides/changelog.md

@@ -13,6 +13,7 @@ description: |-
 - BREAKING CHANGE: Rename `sla_class_list` attribute of `sdwan_application_aware_routing_policy_definition` resource to `sla_class_list_id`
 - BREAKING CHANGE: Rename `preferred_color_group_list` attribute of `sdwan_application_aware_routing_policy_definition` resource to `preferred_color_group_list_id`
 - BREAKING CHANGE: Rename `preferred_color_group_list` attribute of `sdwan_traffic_data_policy_definition` resource to `preferred_color_group_list_id`
+- Fix issue, where NAT IPv4 and IPv6 is always configured on `sdwan_transport_wan_vpn_interface_ethernet_feature`, [link](https://github.com/CiscoDevNet/terraform-provider-sdwan/issues/485)
 - Add missing options under `unsupported_features` attribute of `sdwan_configuration_group`, [link](https://github.com/CiscoDevNet/terraform-provider-sdwan/issues/478)
 - Add `sdwan_policy_group` resource and data source
 - Adds `enhanced_app_aware_routing` support to the `sdwan_cisco_system_feature_template` resource and data source

docs/resources/transport_wan_vpn_interface_ethernet_feature.md

@@ -228,41 +228,41 @@ resource "sdwan_transport_wan_vpn_interface_ethernet_feature" "example" {
 - `media_type` (String) Media type
   - Choices: `auto-select`, `rj45`, `sfp`
 - `media_type_variable` (String) Variable name
-- `nat64` (Boolean) NAT64 on this interface
+- `nat64` (Boolean) NAT64 on this interface, Attribute conditional on `nat_ipv6` being equal to `true`
   - Default value: `false`
-- `nat66` (Boolean) NAT66 on this interface
+- `nat66` (Boolean) NAT66 on this interface, Attribute conditional on `nat_ipv6` being equal to `true`
   - Default value: `false`
 - `nat_ipv4` (Boolean) enable Network Address Translation on this interface
   - Default value: `false`
 - `nat_ipv4_variable` (String) Variable name
 - `nat_ipv6` (Boolean) enable Network Address Translation ipv6 on this interface
   - Default value: `false`
 - `nat_ipv6_variable` (String) Variable name
-- `nat_loopback` (String) NAT Inside Source Loopback Interface
-- `nat_loopback_variable` (String) Variable name
-- `nat_overload` (Boolean) NAT Overload
+- `nat_loopback` (String) NAT Inside Source Loopback Interface, Attribute conditional on `nat_ipv4` being equal to `true`
+- `nat_loopback_variable` (String) Variable name, Attribute conditional on `nat_ipv4` being equal to `true`
+- `nat_overload` (Boolean) NAT Overload, Attribute conditional on `nat_ipv4` being equal to `true`
   - Default value: `true`
-- `nat_overload_variable` (String) Variable name
-- `nat_prefix_length` (Number) NAT Pool Prefix Length
+- `nat_overload_variable` (String) Variable name, Attribute conditional on `nat_ipv4` being equal to `true`
+- `nat_prefix_length` (Number) NAT Pool Prefix Length, Attribute conditional on `nat_ipv4` being equal to `true`
   - Range: `1`-`32`
-- `nat_prefix_length_variable` (String) Variable name
-- `nat_range_end` (String) NAT Pool Range End
-- `nat_range_end_variable` (String) Variable name
-- `nat_range_start` (String) NAT Pool Range Start
-- `nat_range_start_variable` (String) Variable name
-- `nat_tcp_timeout` (Number) Set NAT TCP session timeout, in minutes
+- `nat_prefix_length_variable` (String) Variable name, Attribute conditional on `nat_ipv4` being equal to `true`
+- `nat_range_end` (String) NAT Pool Range End, Attribute conditional on `nat_ipv4` being equal to `true`
+- `nat_range_end_variable` (String) Variable name, Attribute conditional on `nat_ipv4` being equal to `true`
+- `nat_range_start` (String) NAT Pool Range Start, Attribute conditional on `nat_ipv4` being equal to `true`
+- `nat_range_start_variable` (String) Variable name, Attribute conditional on `nat_ipv4` being equal to `true`
+- `nat_tcp_timeout` (Number) Set NAT TCP session timeout, in minutes, Attribute conditional on `nat_ipv4` being equal to `true`
   - Range: `1`-`8947`
   - Default value: `60`
-- `nat_tcp_timeout_variable` (String) Variable name
-- `nat_type` (String) NAT Type
+- `nat_tcp_timeout_variable` (String) Variable name, Attribute conditional on `nat_ipv4` being equal to `true`
+- `nat_type` (String) NAT Type, Attribute conditional on `nat_ipv4` being equal to `true`
   - Choices: `interface`, `pool`, `loopback`
   - Default value: `interface`
-- `nat_type_variable` (String) Variable name
-- `nat_udp_timeout` (Number) Set NAT UDP session timeout, in minutes
+- `nat_type_variable` (String) Variable name, Attribute conditional on `nat_ipv4` being equal to `true`
+- `nat_udp_timeout` (Number) Set NAT UDP session timeout, in minutes, Attribute conditional on `nat_ipv4` being equal to `true`
   - Range: `1`-`8947`
   - Default value: `1`
-- `nat_udp_timeout_variable` (String) Variable name
-- `new_static_nats` (Attributes List) static NAT (see [below for nested schema](#nestedatt--new_static_nats))
+- `nat_udp_timeout_variable` (String) Variable name, Attribute conditional on `nat_ipv4` being equal to `true`
+- `new_static_nats` (Attributes List) static NAT, Attribute conditional on `nat_ipv4` being equal to `true` (see [below for nested schema](#nestedatt--new_static_nats))
 - `per_tunnel_qos` (Boolean) Per-tunnel Qos, Attribute conditional on `tunnel_interface` being equal to `true`
   - Default value: `false`
 - `per_tunnel_qos_variable` (String) Variable name, Attribute conditional on `tunnel_interface` being equal to `true`
@@ -304,7 +304,7 @@ resource "sdwan_transport_wan_vpn_interface_ethernet_feature" "example" {
 - `speed` (String) Set interface speed
   - Choices: `10`, `100`, `1000`, `2500`, `10000`
 - `speed_variable` (String) Variable name
-- `static_nat66` (Attributes List) static NAT66 (see [below for nested schema](#nestedatt--static_nat66))
+- `static_nat66` (Attributes List) static NAT66, Attribute conditional on `nat_ipv6` being equal to `true` (see [below for nested schema](#nestedatt--static_nat66))
 - `tcp_mss` (Number) TCP MSS on SYN packets, in bytes
   - Range: `500`-`1460`
 - `tcp_mss_variable` (String) Variable name

gen/definitions/profile_parcels/transport_wan_vpn_interface_ethernet.yaml

@@ -419,12 +419,20 @@ attributes:
   - model_name: natType
     tf_name: nat_type
     data_path: [natAttributesIpv4]
-    example: interface 
+    example: interface
+    conditional_attribute:
+      name: nat_ipv4
+      value: true
+      type: Bool
   - model_name: rangeStart
     tf_name: nat_range_start
     data_path: [natAttributesIpv4, natPool]
     exclude_test: true
     exclude_null: true
+    conditional_attribute:
+      name: nat_ipv4
+      value: true
+      type: Bool
     # conditional_attribute: 
     #   name: natType
     #   value: pool
@@ -434,6 +442,10 @@ attributes:
     data_path: [natAttributesIpv4, natPool]
     exclude_test: true
     exclude_null: true
+    conditional_attribute:
+      name: nat_ipv4
+      value: true
+      type: Bool
     # conditional_attribute: 
     #   name: natType
     #   value: pool
@@ -443,6 +455,10 @@ attributes:
     data_path: [natAttributesIpv4, natPool]
     exclude_test: true
     exclude_null: true
+    conditional_attribute:
+      name: nat_ipv4
+      value: true
+      type: Bool
     # conditional_attribute: 
     #     name: natType
     #     value: pool
@@ -452,6 +468,10 @@ attributes:
     data_path: [natAttributesIpv4, natPool]
     exclude_test: true
     exclude_null: true
+    conditional_attribute:
+      name: nat_ipv4
+      value: true
+      type: Bool
     # conditional_attribute: 
     #     name: natType
     #     value: pool
@@ -461,6 +481,10 @@ attributes:
     data_path: [natAttributesIpv4]
     exclude_test: true
     exclude_null: true
+    conditional_attribute:
+      name: nat_ipv4
+      value: true
+      type: Bool
     # conditional_attribute: 
     #     name: natType
     #     value: loopback
@@ -469,13 +493,25 @@ attributes:
     tf_name: nat_udp_timeout
     data_path: [natAttributesIpv4]
     example: 1
+    conditional_attribute:
+      name: nat_ipv4
+      value: true
+      type: Bool
   - model_name: tcpTimeout
     tf_name: nat_tcp_timeout
     data_path: [natAttributesIpv4]
     example: 60
+    conditional_attribute:
+      name: nat_ipv4
+      value: true
+      type: Bool
   - model_name: newStaticNat
     tf_name: new_static_nats
     data_path: [natAttributesIpv4]
+    conditional_attribute:
+      name: nat_ipv4
+      value: true
+      type: Bool
     attributes:
       - model_name: sourceIp
         id: true
@@ -496,13 +532,25 @@ attributes:
     data_path: [natAttributesIpv6]
     exclude_null: true
     example: false
+    conditional_attribute:
+      name: nat_ipv6
+      value: true
+      type: Bool
   - model_name: nat66
     data_path: [natAttributesIpv6]
     exclude_null: true
     example: true
+    conditional_attribute:
+      name: nat_ipv6
+      value: true
+      type: Bool
   - model_name: staticNat66
     data_path: [natAttributesIpv6]
     exclude_null: true
+    conditional_attribute:
+      name: nat_ipv6
+      value: true
+      type: Bool
     attributes:
     - model_name: sourcePrefix
       id: true