From 522415a377588bda2a6eeec1a44fefe1b0b423ee Mon Sep 17 00:00:00 2001 From: Sean Conroy Date: Wed, 23 Jul 2025 16:03:29 +0100 Subject: [PATCH] Resolve issue #447 --- docs/resources/localized_policy.md | 7 ----- gen/definitions/generic/localized_policy.yaml | 14 ++++----- .../resource_sdwan_localized_policy.go | 29 +++++-------------- 3 files changed, 14 insertions(+), 36 deletions(-) diff --git a/docs/resources/localized_policy.md b/docs/resources/localized_policy.md index 2b67fbbc6..9e51e8f83 100644 --- a/docs/resources/localized_policy.md +++ b/docs/resources/localized_policy.md @@ -46,20 +46,13 @@ resource "sdwan_localized_policy" "example" { ### Optional - `application_visibility_ipv4` (Boolean) IPv4 application visibility - - Default value: `true` - `application_visibility_ipv6` (Boolean) IPv6 application visibility - - Default value: `true` - `cloud_qos` (Boolean) Cloud QoS - - Default value: `true` - `cloud_qos_service_side` (Boolean) Cloud QoS service side - - Default value: `true` - `definitions` (Attributes Set) List of policy definitions (see [below for nested schema](#nestedatt--definitions)) - `flow_visibility_ipv4` (Boolean) IPv4 flow visibility - - Default value: `true` - `flow_visibility_ipv6` (Boolean) IPv6 flow visibility - - Default value: `true` - `implicit_acl_logging` (Boolean) Implicit ACL logging - - Default value: `true` - `ipv4_visibility_cache_entries` (Number) IPv4 visibility cache entries - Range: `16`-`2000000` - `ipv6_visibility_cache_entries` (Number) IPv6 visibility cache entries diff --git a/gen/definitions/generic/localized_policy.yaml b/gen/definitions/generic/localized_policy.yaml index d907dcacb..fb7b33991 100644 --- a/gen/definitions/generic/localized_policy.yaml +++ b/gen/definitions/generic/localized_policy.yaml @@ -28,49 +28,49 @@ attributes: tf_name: flow_visibility_ipv4 type: Bool description: IPv4 flow visibility - default_value: true + # default_value: true example: true - model_name: flowVisibilityIPv6 data_path: [policyDefinition, settings] tf_name: flow_visibility_ipv6 type: Bool description: IPv6 flow visibility - default_value: true + # default_value: true example: true - model_name: appVisibility data_path: [policyDefinition, settings] tf_name: application_visibility_ipv4 type: Bool description: IPv4 application visibility - default_value: true + # default_value: true example: true - model_name: appVisibilityIPv6 data_path: [policyDefinition, settings] tf_name: application_visibility_ipv6 type: Bool description: IPv6 application visibility - default_value: true + # default_value: true example: true - model_name: cloudQos data_path: [policyDefinition, settings] tf_name: cloud_qos type: Bool description: Cloud QoS - default_value: true + # default_value: true example: true - model_name: cloudQosServiceSide data_path: [policyDefinition, settings] tf_name: cloud_qos_service_side type: Bool description: Cloud QoS service side - default_value: true + # default_value: true example: true - model_name: implicitAclLogging data_path: [policyDefinition, settings] tf_name: implicit_acl_logging type: Bool description: Implicit ACL logging - default_value: true + # default_value: true example: true - model_name: logFrequency data_path: [policyDefinition, settings] diff --git a/internal/provider/resource_sdwan_localized_policy.go b/internal/provider/resource_sdwan_localized_policy.go index f43da4157..0e0147285 100644 --- a/internal/provider/resource_sdwan_localized_policy.go +++ b/internal/provider/resource_sdwan_localized_policy.go @@ -31,7 +31,6 @@ import ( "github.com/hashicorp/terraform-plugin-framework/path" "github.com/hashicorp/terraform-plugin-framework/resource" "github.com/hashicorp/terraform-plugin-framework/resource/schema" - "github.com/hashicorp/terraform-plugin-framework/resource/schema/booldefault" "github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier" "github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier" "github.com/hashicorp/terraform-plugin-framework/schema/validator" @@ -87,46 +86,32 @@ func (r *LocalizedPolicyResource) Schema(ctx context.Context, req resource.Schem Required: true, }, "flow_visibility_ipv4": schema.BoolAttribute{ - MarkdownDescription: helpers.NewAttributeDescription("IPv4 flow visibility").AddDefaultValueDescription("true").String, + MarkdownDescription: helpers.NewAttributeDescription("IPv4 flow visibility").String, Optional: true, - Computed: true, - Default: booldefault.StaticBool(true), }, "flow_visibility_ipv6": schema.BoolAttribute{ - MarkdownDescription: helpers.NewAttributeDescription("IPv6 flow visibility").AddDefaultValueDescription("true").String, + MarkdownDescription: helpers.NewAttributeDescription("IPv6 flow visibility").String, Optional: true, - Computed: true, - Default: booldefault.StaticBool(true), }, "application_visibility_ipv4": schema.BoolAttribute{ - MarkdownDescription: helpers.NewAttributeDescription("IPv4 application visibility").AddDefaultValueDescription("true").String, + MarkdownDescription: helpers.NewAttributeDescription("IPv4 application visibility").String, Optional: true, - Computed: true, - Default: booldefault.StaticBool(true), }, "application_visibility_ipv6": schema.BoolAttribute{ - MarkdownDescription: helpers.NewAttributeDescription("IPv6 application visibility").AddDefaultValueDescription("true").String, + MarkdownDescription: helpers.NewAttributeDescription("IPv6 application visibility").String, Optional: true, - Computed: true, - Default: booldefault.StaticBool(true), }, "cloud_qos": schema.BoolAttribute{ - MarkdownDescription: helpers.NewAttributeDescription("Cloud QoS").AddDefaultValueDescription("true").String, + MarkdownDescription: helpers.NewAttributeDescription("Cloud QoS").String, Optional: true, - Computed: true, - Default: booldefault.StaticBool(true), }, "cloud_qos_service_side": schema.BoolAttribute{ - MarkdownDescription: helpers.NewAttributeDescription("Cloud QoS service side").AddDefaultValueDescription("true").String, + MarkdownDescription: helpers.NewAttributeDescription("Cloud QoS service side").String, Optional: true, - Computed: true, - Default: booldefault.StaticBool(true), }, "implicit_acl_logging": schema.BoolAttribute{ - MarkdownDescription: helpers.NewAttributeDescription("Implicit ACL logging").AddDefaultValueDescription("true").String, + MarkdownDescription: helpers.NewAttributeDescription("Implicit ACL logging").String, Optional: true, - Computed: true, - Default: booldefault.StaticBool(true), }, "log_frequency": schema.Int64Attribute{ MarkdownDescription: helpers.NewAttributeDescription("Log frequency").AddIntegerRangeDescription(1, 2147483647).String,