Skip to content

Commit 6e81f5d

Browse files
committed
Process PR comments
1 parent fd91f99 commit 6e81f5d

File tree

4 files changed

+36
-10
lines changed

4 files changed

+36
-10
lines changed

src/ActionHandler/NotificationCaseHandler.php

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,20 @@
55
use CommonGateway\VrijBRPToZGWBundle\Service\NewSynchronizationService;
66
use CommonGateway\VrijBRPToZGWBundle\Service\VrijBrpService;
77
use CommonGateway\CoreBundle\ActionHandler\ActionHandlerInterface;
8-
8+
/**
9+
* Handler for firing notifications for new cases.
10+
*
11+
* @author Robert Zondervan, Barry Brands, Ruben van der Linde
12+
* @license EUPL<github.com/ConductionNL/contactcatalogus/blob/master/LICENSE.md>
13+
*
14+
* @category ActionHandler
15+
*/
916
class NotificationCaseHandler implements ActionHandlerInterface
1017
{
1118

12-
19+
/**
20+
* @param VrijBrpService $vrijBrpService The VrijBRP Service
21+
*/
1322
public function __construct(
1423
private readonly VrijBrpService $vrijBrpService,
1524
) {
@@ -21,6 +30,7 @@ public function __construct(
2130
* This function returns the requered configuration as a [json-schema](https://json-schema.org/) array.
2231
*
2332
* @throws array a [json-schema](https://json-schema.org/) that this action should comply to
33+
* @return array The default configuration options of this action handler.
2434
*/
2535
public function getConfiguration(): array
2636
{
@@ -42,7 +52,7 @@ public function getConfiguration(): array
4252
* @param array $data The data from the call
4353
* @param array $configuration The configuration of the action
4454
*
45-
* @return array
55+
* @return array The updated data array
4656
*/
4757
public function run(array $data, array $configuration): array
4858
{

src/ActionHandler/NotificationUpdateHandler.php

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,21 @@
66
use CommonGateway\VrijBRPToZGWBundle\Service\VrijBrpService;
77
use CommonGateway\CoreBundle\ActionHandler\ActionHandlerInterface;
88

9+
/**
10+
* Handler for firing notifications for new statuses.
11+
*
12+
* @author Robert Zondervan, Barry Brands, Ruben van der Linde
13+
* @license EUPL<github.com/ConductionNL/contactcatalogus/blob/master/LICENSE.md>
14+
*
15+
* @category ActionHandler
16+
*/
917
class NotificationUpdateHandler implements ActionHandlerInterface
1018
{
1119

1220

21+
/**
22+
* @param VrijBrpService $vrijBrpService The VrijBRP Service
23+
*/
1324
public function __construct(
1425
private readonly VrijBrpService $vrijBrpService,
1526
) {
@@ -21,6 +32,7 @@ public function __construct(
2132
* This function returns the requered configuration as a [json-schema](https://json-schema.org/) array.
2233
*
2334
* @throws array a [json-schema](https://json-schema.org/) that this action should comply to
35+
* @return array The default configuration options of this action handler.
2436
*/
2537
public function getConfiguration(): array
2638
{
@@ -42,7 +54,7 @@ public function getConfiguration(): array
4254
* @param array $data The data from the call
4355
* @param array $configuration The configuration of the action
4456
*
45-
* @return array
57+
* @return array The updated data array.
4658
*/
4759
public function run(array $data, array $configuration): array
4860
{

src/ActionHandler/SynchronizeCollectionHandler.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ class SynchronizeCollectionHandler implements ActionHandlerInterface
1919

2020

2121
/**
22-
* @param NewSynchronizationService $syncService
23-
* @param VrijBrpService $vrijBrpService
22+
* @param NewSynchronizationService $syncService The synchronization service.
23+
* @param VrijBrpService $vrijBrpService The VrijBRP service.
2424
*/
2525
public function __construct(
2626
private readonly NewSynchronizationService $syncService,

src/Service/VrijBrpService.php

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ public function __construct(
4242
* Set defaults for configuration of synchronize action.
4343
*
4444
* @param array $configuration Incoming configuration.
45-
* @return array
45+
*
46+
* @return array The updated configuration array.
4647
*/
4748
public function setVrijBRPDefaults(array $configuration): array
4849
{
@@ -73,7 +74,8 @@ public function setVrijBRPDefaults(array $configuration): array
7374
*
7475
* @param array $data incoming data.
7576
* @param array $config incoming configuration.
76-
* @return array
77+
*
78+
* @return array The updated data array.
7779
*/
7880
public function createStatusNotification(array $data, array $config): array
7981
{
@@ -110,7 +112,8 @@ public function createStatusNotification(array $data, array $config): array
110112
*
111113
* @param ObjectEntity $object Incoming object
112114
* @param array $array Serialised incoming object
113-
* @return ObjectEntity
115+
*
116+
* @return ObjectEntity The updated objectEntity.
114117
*/
115118
public function extendSync(ObjectEntity $object, array $array): ObjectEntity
116119
{
@@ -141,7 +144,8 @@ public function extendSync(ObjectEntity $object, array $array): ObjectEntity
141144
*
142145
* @param array $data Incoming data
143146
* @param array $config Incoming configuration
144-
* @return array
147+
*
148+
* @return array The updated data array.
145149
*/
146150
public function createCaseNotification(array $data, array $config): array
147151
{

0 commit comments

Comments
 (0)