Skip to content

Commit 55c521d

Browse files
committed
fix(surrealdb): escape password value
1 parent b88f9c2 commit 55c521d

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/CommunityToolkit.Aspire.Hosting.SurrealDb/SurrealDbServerResource.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ UserNameParameter is not null ?
5454

5555
private ReferenceExpression ConnectionString =>
5656
ReferenceExpression.Create(
57-
$"Server={SchemeUri}://{PrimaryEndpoint.Property(EndpointProperty.Host)}:{PrimaryEndpoint.Property(EndpointProperty.Port)}/rpc;User={UserNameReference};Password={PasswordParameter}");
57+
$"Server={SchemeUri}://{PrimaryEndpoint.Property(EndpointProperty.Host)}:{PrimaryEndpoint.Property(EndpointProperty.Port)}/rpc;User={UserNameReference};Password='{PasswordParameter}'");
5858

5959
/// <summary>
6060
/// Gets the connection string expression for the SurrealDB instance.

tests/CommunityToolkit.Aspire.Hosting.SurrealDb.Tests/AddSurrealServerTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,8 @@ public async Task SurrealServerCreatesConnectionString()
9191
var connectionStringResource = Assert.Single(appModel.Resources.OfType<SurrealDbServerResource>());
9292
var connectionString = await connectionStringResource.GetConnectionStringAsync(default);
9393

94-
Assert.Equal("Server=ws://localhost:8000/rpc;User=root;Password=p@ssw0rd1", connectionString);
95-
Assert.Equal("Server=ws://{surreal.bindings.tcp.host}:{surreal.bindings.tcp.port}/rpc;User=root;Password={pass.value}", connectionStringResource.ConnectionStringExpression.ValueExpression);
94+
Assert.Equal("Server=ws://localhost:8000/rpc;User=root;Password='p@ssw0rd1'", connectionString);
95+
Assert.Equal("Server=ws://{surreal.bindings.tcp.host}:{surreal.bindings.tcp.port}/rpc;User=root;Password='{pass.value}'", connectionStringResource.ConnectionStringExpression.ValueExpression);
9696
}
9797

9898
[Fact]
@@ -116,7 +116,7 @@ public async Task SurrealServerDatabaseCreatesConnectionString()
116116
var connectionStringResource = (IResourceWithConnectionString)surrealResource;
117117
var connectionString = await connectionStringResource.GetConnectionStringAsync();
118118

119-
Assert.Equal("Server=ws://localhost:8000/rpc;User=root;Password=p@ssw0rd1;Namespace=myns;Database=mydb", connectionString);
119+
Assert.Equal("Server=ws://localhost:8000/rpc;User=root;Password='p@ssw0rd1';Namespace=myns;Database=mydb", connectionString);
120120
Assert.Equal("{ns.connectionString};Database=mydb", connectionStringResource.ConnectionStringExpression.ValueExpression);
121121
}
122122

0 commit comments

Comments
 (0)