Skip to content

Commit 6689131

Browse files
authored
Apply suggestions from code review
1 parent f16b0f3 commit 6689131

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/CommunityToolkit.Aspire.Hosting.Minio/MinioBuilderExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ public static IResourceBuilder<MinioContainerResource> AddMinioContainer(
4646
.WithImageRegistry(MinioContainerImageTags.Registry)
4747
.WithHttpEndpoint(targetPort: 9000, port: port, name: MinioContainerResource.PrimaryEndpointName)
4848
.WithHttpEndpoint(targetPort: consoleTargetPort, name: MinioContainerResource.ConsoleEndpointName)
49-
.WithEnvironment(RootUserEnvVarName, resource.RootUser)
50-
.WithEnvironment(RootPasswordEnvVarName, resource.PasswordParameter)
49+
.WithEnvironment(RootUserEnvVarName, $"{resource.RootUser}")
50+
.WithEnvironment(RootPasswordEnvVarName, $"{resource.PasswordParameter}")
5151
.WithArgs("server", "/data", "--console-address", $":{consoleTargetPort}");
5252

5353
var endpoint = builderWithResource.Resource.GetEndpoint(MinioContainerResource.PrimaryEndpointName);

src/CommunityToolkit.Aspire.Hosting.Redis.Extensions/RedisBuilderExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ private static void ConfigureDbGateContainer(EnvironmentCallbackContext context,
6565

6666
// DbGate assumes Redis is being accessed over a default Aspire container network and hardcodes the resource address
6767
var redisUrl = redisResource.PasswordParameter is not null ?
68-
ReferenceExpression.Create($"redis://:{redisResource.PasswordParameter}@{redisResource.Name}:{redisResource.PrimaryEndpoint.TargetPort}") :
69-
ReferenceExpression.Create($"redis://{redisResource.Name}:{redisResource.PrimaryEndpoint.TargetPort}");
68+
ReferenceExpression.Create($"redis://:{redisResource.PasswordParameter}@{redisResource.Name}:{redisResource.PrimaryEndpoint.TargetPort?.ToString()}") :
69+
ReferenceExpression.Create($"redis://{redisResource.Name}:{redisResource.PrimaryEndpoint.TargetPort?.ToString()}");
7070

7171
context.EnvironmentVariables.Add($"LABEL_redis{counter}", redisResource.Name);
7272
context.EnvironmentVariables.Add($"URL_redis{counter}", redisUrl);

0 commit comments

Comments
 (0)