handling Windows invocation of npm and associated commands

Author: aaronpowell

src/Aspire.CommunityToolkit.Hosting.NodeJS.Extensions/NodePackageInstaller.cs

@@ -60,7 +60,7 @@ await notificationService.PublishUpdateAsync(resource, state => state with
 
         logger.LogInformation("Installing {PackageManager} packages in {WorkingDirectory}", packageManager, resource.WorkingDirectory);
 
-        var packageInstaller = new Process
+        var packageInstaller = !RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? => new Process
         {
             StartInfo = new ProcessStartInfo
             {
@@ -69,51 +69,64 @@ await notificationService.PublishUpdateAsync(resource, state => state with
                 WorkingDirectory = resource.WorkingDirectory,
                 RedirectStandardOutput = true,
                 RedirectStandardError = true,
-                UseShellExecute = false,
-                CreateNoWindow = true
+                CreateNoWindow = true,
+                UseShellExecute = true,
             }
-        };
-
-        packageInstaller.OutputDataReceived += async (sender, args) =>
-        {
-            if (!string.IsNullOrWhiteSpace(args.Data))
+            : new Process
             {
-                await notificationService.PublishUpdateAsync(resource, state => state with
+                StartInfo = new ProcessStartInfo
                 {
-                    State = new(args.Data, KnownResourceStates.Starting)
-                }).ConfigureAwait(false);
-
-                logger.LogInformation("{Data}", args.Data);
+                    FileName = "cmd",
+                    Arguments = $"/c {packageManager} install",
+                    WorkingDirectory = resource.WorkingDirectory,
+                    RedirectStandardOutput = true,
+                    RedirectStandardError = true,
+                    CreateNoWindow = true,
+                    UseShellExecute = false,
+                }
             }
         };
 
-        packageInstaller.ErrorDataReceived += async (sender, args) =>
+    packageInstaller.OutputDataReceived += async(sender, args) =>
         {
             if (!string.IsNullOrWhiteSpace(args.Data))
             {
                 await notificationService.PublishUpdateAsync(resource, state => state with
                 {
-                    State = new(args.Data, KnownResourceStates.FailedToStart)
+        State = new(args.Data, KnownResourceStates.Starting)
                 }).ConfigureAwait(false);
 
-                logger.LogError("{Data}", args.Data);
+    logger.LogInformation("{Data}", args.Data);
             }
         };
 
-        packageInstaller.Start();
-        packageInstaller.BeginOutputReadLine();
-        packageInstaller.BeginErrorReadLine();
+packageInstaller.ErrorDataReceived += async (sender, args) =>
+{
+    if (!string.IsNullOrWhiteSpace(args.Data))
+    {
+        await notificationService.PublishUpdateAsync(resource, state => state with
+        {
+            State = new(args.Data, KnownResourceStates.FailedToStart)
+        }).ConfigureAwait(false);
+
+        logger.LogError("{Data}", args.Data);
+    }
+};
 
-        packageInstaller.WaitForExit();
+packageInstaller.Start();
+packageInstaller.BeginOutputReadLine();
+packageInstaller.BeginErrorReadLine();
 
-        if (packageInstaller.ExitCode != 0)
-        {
-            await notificationService.PublishUpdateAsync(resource, state => state with
-            {
-                State = new($"{packageManager} exited with {packageInstaller.ExitCode}", KnownResourceStates.FailedToStart)
-            }).ConfigureAwait(false);
+packageInstaller.WaitForExit();
 
-            throw new InvalidOperationException($"{packageManager} install failed with exit code {packageInstaller.ExitCode}");
-        }
+if (packageInstaller.ExitCode != 0)
+{
+    await notificationService.PublishUpdateAsync(resource, state => state with
+    {
+        State = new($"{packageManager} exited with {packageInstaller.ExitCode}", KnownResourceStates.FailedToStart)
+    }).ConfigureAwait(false);
+
+    throw new InvalidOperationException($"{packageManager} install failed with exit code {packageInstaller.ExitCode}");
+}
     }
 }