Test updates

Author: mikera

convex-core/src/test/java/convex/core/data/BlobsTest.java

@@ -11,7 +11,6 @@
 
 import java.io.IOException;
 import java.nio.ByteBuffer;
-import java.util.Arrays;
 import java.util.Random;
 
 import org.junit.jupiter.api.Test;
@@ -31,7 +30,7 @@
 
 public class BlobsTest {
 	@Test public void testConstants() {
-		assertEquals(4096,Blob.CHUNK_LENGTH);
+		assertEquals(4096,Blob.CHUNK_LENGTH); // verify expected constant value of 4k
 		assertEquals(Blob.CHUNK_LENGTH,1<<Blobs.CHUNK_SHIFT);
 	}
 
@@ -340,6 +339,20 @@ public void testBlobSlice() {
 		doBlobTests(blob);
 	}
 
+	@Test
+	public void testSliceInvalidRanges() {
+	    Blob b = Blob.fromHex("0123456789");
+	    
+	    // start > end
+	    assertNull(b.slice(3, 2));
+	    
+	    // negative length implicitly
+	    assertNull(b.slice(5, 4));
+	    
+	    // valid edge case
+	    assertEquals(Blob.EMPTY, b.slice(3, 3));
+	}
+	
 	@Test
 	public void testBlobAppendSmall() {
 		ABlob src = Blob.fromHex("cafebabedeadbeef");
@@ -433,29 +446,42 @@ public void testBlobTreeDepthLimits() {
 	    assertEquals(1000, result.count());
 	}
 
+	@Test
+	public void testInstanceReuseOptimizations() {
+	    Blob b = Blob.fromHex("0123456789abcdef");
+	    
+	    // Full slice should return same instance
+	    assertSame(b, b.slice(0));
+	    assertSame(b, b.slice(0, b.count()));
+	    
+	    // Empty slices should return empty singleton
+	    assertSame(Blob.EMPTY, b.slice(5, 5));
+	    assertSame(Blob.EMPTY, b.slice(b.count()));
+	    	    
+	
+	}
+	
 	@Test
 	public void testCompareConsistency() {
 	    // Ensure compareTo is consistent with equals
-	    java.util.List<Blob> blobs = Arrays.asList(
+	    Blob[] blobs = new Blob[] {
 	        Blob.EMPTY,
 	        Blob.fromHex("00"),
 	        Blob.fromHex("01"),
 	        Blob.fromHex("FF"),
 	        Blob.fromHex("0000"),
 	        Blob.fromHex("0001"),
 	        Blob.fromHex("FFFF")
-	    );
+	    };
 
 	    for (Blob b1 : blobs) {
 	        for (Blob b2 : blobs) {
 	            // If equal, compareTo should return 0
-	            if (b1.equals(b2)) {
-	                assertEquals(0, b1.compareTo(b2));
-	            }
 
 	            // compareTo should be antisymmetric
 	            assertEquals(-Integer.signum(b1.compareTo(b2)), Integer.signum(b2.compareTo(b1)));
 	        }
+	        doBlobTests(b1);
 	    }
 	}
 

convex-core/src/test/java/convex/core/util/EconomicsTest.java

@@ -9,8 +9,6 @@
 
 import org.junit.jupiter.api.Test;
 
-import convex.core.util.Economics;
-
 public class EconomicsTest {
 
 	@Test

convex-core/src/test/java/convex/core/util/GenTestEconomics.java

@@ -10,9 +10,6 @@
 import com.pholser.junit.quickcheck.Property;
 import com.pholser.junit.quickcheck.runner.JUnitQuickcheck;
 
-import convex.core.util.Economics;
-import convex.core.util.Utils;
-
 @RunWith(JUnitQuickcheck.class)
 public class GenTestEconomics {