Faster printing for Long values

Author: mikera

convex-core/src/main/java/convex/core/data/Address.java

@@ -206,7 +206,7 @@ public int encodeRaw(byte[] bs, int pos) {
 	@Override
 	public boolean print(BlobBuilder sb, long limit) {
 		sb.append("#");
-		sb.append(Long.toString(value));
+		sb.appendLongString(value);
 		return sb.check(limit);
 	}
 

convex-core/src/main/java/convex/core/data/Strings.java

@@ -62,6 +62,8 @@ public class Strings {
 
 	public static final StringShort PRINT_EXCEEDED = StringShort.create(Constants.PRINT_EXCEEDED_STRING);
 
+	public static final StringShort LONG_MIN_VALUE = StringShort.create("-9223372036854775808");
+
 
 	/**
 	 * Reads a String from a Blob encoding.

convex-core/src/main/java/convex/core/data/prim/CVMLong.java

@@ -151,7 +151,7 @@ public static CVMLong read(byte tag, Blob blob, int offset) throws BadFormatExce
 
 	@Override
 	public boolean print(BlobBuilder bb, long limit) {
-		bb.append(toCVMString(20));
+		bb.appendLongString(value);
 		return bb.check(limit);
 	}
 

convex-core/src/main/java/convex/core/data/util/BlobBuilder.java

@@ -169,6 +169,33 @@ public void append(String string) {
 		append(Strings.create(string));
 	}
 
+	/**
+	 * Appends a long value as a UTF-8 string
+	 * @param value
+	 */
+	public void appendLongString(long value) {
+		if (value==Long.MIN_VALUE) {
+			append(Strings.LONG_MIN_VALUE);
+			return;
+		}
+		if (value<0) {
+			append('-');
+			value=-value;
+		};
+		int n=Utils.longStringSize(value);
+		if (n==1) {
+			append((byte)('0'+value));
+			return;
+		}
+		
+		byte[] bs=new byte[n];
+		for (int i=0; i<n; i++) {
+			bs[n-i-1]=(byte)('0'+(value%10));
+			value/=10;
+		}
+		append(bs);
+	}
+	
 	public BlobBuilder append(byte b) {
 		int spare=spare();
 		if (spare<1) throw new Panic("BlobBuilder should always have spare bytes but was: "+spare);

convex-core/src/main/java/convex/core/util/Utils.java

@@ -878,7 +878,20 @@ public static void print(StringBuilder sb,Object v) {
 		}
 	}
 
-
+	public static int longStringSize(long x) {
+        int d = 1;
+        if (x >= 0) {
+            d = 0;
+            x = -x;
+        }
+        long p = -10;
+        for (int i = 1; i < 19; i++) {
+            if (x > p)
+                return i + d;
+            p = 10 * p;
+        }
+        return 19 + d;
+    }
 
 	/**
 	 * Filters the array, returning an array containing only the elements where the