Skip to content

Commit b8fb65f

Browse files
committed
fix(front): show deployment info inline instead of navigating to a new page
1 parent 728dc38 commit b8fb65f

File tree

1 file changed

+34
-15
lines changed

1 file changed

+34
-15
lines changed

nebula/frontend/templates/deployment.html

Lines changed: 34 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ <h5 class="step-title">Dataset type</h5>
313313
<i id="iidHelpIcon" class="fa fa-info-circle" style="cursor: pointer;"></i>
314314
</small>
315315
</div>
316-
<h5 class="step-title">Partition Methods</h5>
316+
<h5 class="step-title">Partition methods</h5>
317317
<div class="form-check form-check-inline">
318318
<select class="form-control" id="partitionSelect" name="partition"
319319
style="display: inline; width: 50%">
@@ -1446,9 +1446,17 @@ <h5 class="step-title">Schema of deployment</h5>
14461446
' <li>Manual: Select malicious nodes in the graph</li>\n' +
14471447
' </ul>'
14481448

1449+
contentProcessHelp = '<ul>\n' +
1450+
' <li>Processes: Deploy the nodes of the federation using processes</li>\n' +
1451+
' </ul>';
1452+
1453+
contentDockerHelp = '<ul>\n' +
1454+
' <li>Docker: Deploy the nodes of the federation using docker containers</li>\n' +
1455+
' </ul>';
1456+
14491457
var popoverTriggerEl = document.getElementById("topologyCustomIcon");
14501458
var popover = new bootstrap.Popover(popoverTriggerEl, {
1451-
title: "Network topology",
1459+
title: "Topology generation",
14521460
content: contentTopologyCustomHelp,
14531461
trigger: "hover",
14541462
placement: "right",
@@ -1459,7 +1467,7 @@ <h5 class="step-title">Schema of deployment</h5>
14591467

14601468
var popoverTriggerEl = document.getElementById("topologyPredefinedIcon");
14611469
var popover = new bootstrap.Popover(popoverTriggerEl, {
1462-
title: "Network topology",
1470+
title: "Topology generation",
14631471
content: contentTopologyPredefinedHelp,
14641472
trigger: "hover",
14651473
placement: "right",
@@ -1470,7 +1478,7 @@ <h5 class="step-title">Schema of deployment</h5>
14701478

14711479
var popoverTriggerEl = document.getElementById("architectureHelpIcon");
14721480
var popover = new bootstrap.Popover(popoverTriggerEl, {
1473-
title: "Federation architecture",
1481+
title: "Federation approach",
14741482
content: contentArchitectureHelp,
14751483
trigger: "hover",
14761484
placement: "right",
@@ -1481,7 +1489,7 @@ <h5 class="step-title">Schema of deployment</h5>
14811489

14821490
var popoverTriggerEl = document.getElementById("datasetHelpIcon");
14831491
var popover = new bootstrap.Popover(popoverTriggerEl, {
1484-
title: "Dataset",
1492+
title: "Federated dataset",
14851493
content: contentDatasetHelp,
14861494
trigger: "hover",
14871495
placement: "right",
@@ -1492,7 +1500,7 @@ <h5 class="step-title">Schema of deployment</h5>
14921500

14931501
var popoverTriggerEl = document.getElementById("iidHelpIcon");
14941502
var popover = new bootstrap.Popover(popoverTriggerEl, {
1495-
title: "IID",
1503+
title: "Dataset type",
14961504
content: contentIIDHelp,
14971505
trigger: "hover",
14981506
placement: "right",
@@ -1503,7 +1511,7 @@ <h5 class="step-title">Schema of deployment</h5>
15031511

15041512
var popoverTriggerEl = document.getElementById("partitionMethodsHelpIcon");
15051513
var popover = new bootstrap.Popover(popoverTriggerEl, {
1506-
title: 'Partition Methods',
1514+
title: 'Partition methods',
15071515
content: contentPartitionMethodsHelp,
15081516
trigger: 'hover',
15091517
placement: 'right',
@@ -1514,7 +1522,7 @@ <h5 class="step-title">Schema of deployment</h5>
15141522

15151523
var popoverTriggerEl = document.getElementById("parameterSettingHelpIcon");
15161524
var popover = new bootstrap.Popover(popoverTriggerEl, {
1517-
title: 'IID',
1525+
title: 'Parameter setting',
15181526
html: true,
15191527
placement: 'right',
15201528
content: contentParameterSettingHelp,
@@ -1545,15 +1553,26 @@ <h5 class="step-title">Schema of deployment</h5>
15451553
delay: { show: 500, hide: 100 },
15461554
});
15471555

1548-
// When click processHelpIcon, redirect to the documentation page
1549-
var processIcon = document.getElementById("processHelpIcon");
1550-
processIcon.addEventListener("click", function () {
1551-
window.open("#", "_blank");
1556+
var popoverTriggerEl = document.getElementById("processHelpIcon");
1557+
var popover = new bootstrap.Popover(popoverTriggerEl, {
1558+
title: "Deployment type",
1559+
content: contentProcessHelp,
1560+
trigger: "hover",
1561+
placement: "right",
1562+
html: true,
1563+
container: "body",
1564+
delay: { show: 500, hide: 100 },
15521565
});
15531566

1554-
var dockerIcon = document.getElementById("dockerHelpIcon");
1555-
dockerIcon.addEventListener("click", function () {
1556-
window.open("#", "_blank");
1567+
var popoverTriggerEl = document.getElementById("dockerHelpIcon");
1568+
var popover = new bootstrap.Popover(popoverTriggerEl, {
1569+
title: "Deployment type",
1570+
content: contentDockerHelp,
1571+
trigger: "hover",
1572+
placement: "right",
1573+
html: true,
1574+
container: "body",
1575+
delay: { show: 500, hide: 100 },
15571576
});
15581577
</script>
15591578

0 commit comments

Comments
 (0)