deleting the last work order throws a lua error in `confirm`

[ab9rf]

.../hack/scripts/internal/confirm/specs.lua:464: Cannot read field vector<manager_order*>.88: index out of bounds.
stack traceback:
        [C]: in metamethod '__index'
        .../hack/scripts/internal/confirm/specs.lua:464: in function <...F/df_52_03_steam/hack/scripts/internal/confirm/specs.lua:457>
        (...tail calls...)
        .../hack/scripts/confirm.lua:134: in function <E:/Kelly/DF/df_52_03_steam/hack/scripts/confirm.lua:110>
        (...tail calls...)
        ...\hack\lua\plugins\overlay.lua:435: in upvalue 'detect_frame_change'
        ...\hack\lua\plugins\overlay.lua:524: in upvalue '_feed_viewscreen_widgets'
        ...\hack\lua\plugins\overlay.lua:534: in function 'plugins.overlay.feed_viewscreen_widgets'
Failed Lua call to 'plugins.overlay.feed_viewscreen_widgets'

[ChrisJohnsen]

I think this might be addressed by a commit in scripts PR 1446.

The commit describes the situation, but it involves

1. being scrolled to the bottom of a multi-page list of orders, and
2. either
   • resizing the DF window so that more orders are displayed, or
   • deleting an order

Subsequent order deletions at the bottom of the list will cause this out of bounds error. More than just the last order can be affected if DF has "pushed" multiple orders in at the top of the list. Also, it doesn't just affect the orders at the end of the list: the removal confirmation descriptions for earlier orders will be "off by N".

The error situation can be "cleared" by scrolling the order list up (and possibly back down).

[ab9rf]

I have confirmed that this is fixed by DFHack/scripts#1446