Fix dewar prefix

Author: gfrn

src/scaup/crud/top_level_containers.py

@@ -16,7 +16,7 @@
 from ..utils.external import ExternalRequest
 from ..utils.session import retry_if_exists
 
-DEWAR_PREFIX = "DLS-BI-"
+DEWAR_PREFIX = "DLS-BI-1"
 
 
 def _check_fields(
@@ -82,7 +82,7 @@ def create_top_level_container(shipmentId: int | None, params: TopLevelContainer
             last_dewar = int(ext_get.json()["items"][0]["facilityCode"].split("-")[2])
             dewar_number = 1000 if last_dewar < 1000 else last_dewar + 1
 
-        new_code = f"{DEWAR_PREFIX}{dewar_number:04}"
+        new_code = f"DLS-BI-{dewar_number:04}"
 
         proposal_reference = inner_db.session.scalar(
             select(func.concat(Shipment.proposalCode, Shipment.proposalNumber)).filter(Shipment.id == shipmentId)

tests/shipments/top_level_containers/test_create.py

@@ -66,7 +66,7 @@ def test_create_no_code(client):
     )
 
     responses.get(
-        f"{Config.ispyb_api.url}/dewar-registry?search=DLS-BI-&limit=1",
+        f"{Config.ispyb_api.url}/dewar-registry?search=DLS-BI-1&limit=1",
         status=200,
         json={"items": [{"facilityCode": "DLS-BI-5671"}]},
     )
@@ -90,7 +90,7 @@ def test_create_no_code(client):
 def test_no_items_in_ispyb(client):
     """Should set generated code index to 1000 if Expeye returns no dewar registry items"""
     responses.get(
-        f"{Config.ispyb_api.url}/dewar-registry?search=DLS-BI-&limit=1",
+        f"{Config.ispyb_api.url}/dewar-registry?search=DLS-BI-1&limit=1",
         status=200,
         json={"items": []},
     )
@@ -120,7 +120,7 @@ def test_no_items_in_ispyb(client):
 def test_create_no_code_expeye_out_of_range(client):
     """Should set generated code index to 1000 if Expeye returns a code which is out of eBIC's range"""
     responses.get(
-        f"{Config.ispyb_api.url}/dewar-registry?search=DLS-BI-&limit=1",
+        f"{Config.ispyb_api.url}/dewar-registry?search=DLS-BI-1&limit=1",
         status=200,
         json={"items": [{"facilityCode": "DLS-BI-0008"}]},
     )
@@ -158,7 +158,7 @@ def test_create_no_code_expeye_out_of_range(client):
 def test_upstream_failure(client, status_get, status_post):
     """Should raise exception if request fails upstream"""
     responses.get(
-        f"{Config.ispyb_api.url}/dewar-registry?search=DLS-BI-&limit=1",
+        f"{Config.ispyb_api.url}/dewar-registry?search=DLS-BI-1&limit=1",
         status=status_get,
         json={"items": [{"facilityCode": "DLS-BI-5671"}]},
     )