Skip to content

Commit 4799a09

Browse files
Use the better constructJobInfo() in DownloadMediaService when downloading media in an imgur album.
1 parent 3552a9a commit 4799a09

File tree

2 files changed

+4
-16
lines changed

2 files changed

+4
-16
lines changed

app/src/main/java/ml/docilealligator/infinityforreddit/fragments/ViewImgurImageFragment.java

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import android.os.Build;
1313
import android.os.Bundle;
1414
import android.os.Handler;
15-
import android.os.PersistableBundle;
1615
import android.view.LayoutInflater;
1716
import android.view.Menu;
1817
import android.view.MenuInflater;
@@ -43,14 +42,14 @@
4342
import javax.inject.Inject;
4443

4544
import ml.docilealligator.infinityforreddit.BuildConfig;
46-
import ml.docilealligator.infinityforreddit.post.ImgurMedia;
4745
import ml.docilealligator.infinityforreddit.Infinity;
4846
import ml.docilealligator.infinityforreddit.R;
4947
import ml.docilealligator.infinityforreddit.SetAsWallpaperCallback;
5048
import ml.docilealligator.infinityforreddit.activities.ViewImgurMediaActivity;
5149
import ml.docilealligator.infinityforreddit.asynctasks.SaveBitmapImageToFile;
5250
import ml.docilealligator.infinityforreddit.bottomsheetfragments.SetAsWallpaperBottomSheetFragment;
5351
import ml.docilealligator.infinityforreddit.databinding.FragmentViewImgurImageBinding;
52+
import ml.docilealligator.infinityforreddit.post.ImgurMedia;
5453
import ml.docilealligator.infinityforreddit.services.DownloadMediaService;
5554
import ml.docilealligator.infinityforreddit.utils.Utils;
5655

@@ -224,13 +223,8 @@ private void requestPermissionAndDownload() {
224223
private void download() {
225224
isDownloading = false;
226225

227-
PersistableBundle extras = new PersistableBundle();
228-
extras.putString(DownloadMediaService.EXTRA_URL, imgurMedia.getLink());
229-
extras.putInt(DownloadMediaService.EXTRA_MEDIA_TYPE, DownloadMediaService.EXTRA_MEDIA_TYPE_IMAGE);
230-
extras.putString(DownloadMediaService.EXTRA_FILE_NAME, imgurMedia.getFileName());
231-
232226
//TODO: contentEstimatedBytes
233-
JobInfo jobInfo = DownloadMediaService.constructJobInfo(activity, 5000000, extras);
227+
JobInfo jobInfo = DownloadMediaService.constructJobInfo(activity, 5000000, imgurMedia);
234228
((JobScheduler) activity.getSystemService(Context.JOB_SCHEDULER_SERVICE)).schedule(jobInfo);
235229

236230
Toast.makeText(activity, R.string.download_started, Toast.LENGTH_SHORT).show();

app/src/main/java/ml/docilealligator/infinityforreddit/fragments/ViewImgurVideoFragment.java

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import android.media.AudioManager;
1212
import android.os.Build;
1313
import android.os.Bundle;
14-
import android.os.PersistableBundle;
1514
import android.view.LayoutInflater;
1615
import android.view.Menu;
1716
import android.view.MenuInflater;
@@ -49,12 +48,12 @@
4948
import javax.inject.Inject;
5049
import javax.inject.Named;
5150

52-
import ml.docilealligator.infinityforreddit.post.ImgurMedia;
5351
import ml.docilealligator.infinityforreddit.Infinity;
5452
import ml.docilealligator.infinityforreddit.R;
5553
import ml.docilealligator.infinityforreddit.activities.ViewImgurMediaActivity;
5654
import ml.docilealligator.infinityforreddit.bottomsheetfragments.PlaybackSpeedBottomSheetFragment;
5755
import ml.docilealligator.infinityforreddit.databinding.FragmentViewImgurVideoBinding;
56+
import ml.docilealligator.infinityforreddit.post.ImgurMedia;
5857
import ml.docilealligator.infinityforreddit.services.DownloadMediaService;
5958
import ml.docilealligator.infinityforreddit.utils.APIUtils;
6059
import ml.docilealligator.infinityforreddit.utils.SharedPreferencesUtils;
@@ -260,13 +259,8 @@ public void onRequestPermissionsResult(int requestCode, @NonNull String[] permis
260259
private void download() {
261260
isDownloading = false;
262261

263-
PersistableBundle extras = new PersistableBundle();
264-
extras.putString(DownloadMediaService.EXTRA_URL, imgurMedia.getLink());
265-
extras.putInt(DownloadMediaService.EXTRA_MEDIA_TYPE, DownloadMediaService.EXTRA_MEDIA_TYPE_VIDEO);
266-
extras.putString(DownloadMediaService.EXTRA_FILE_NAME, imgurMedia.getFileName());
267-
268262
//TODO: contentEstimatedBytes
269-
JobInfo jobInfo = DownloadMediaService.constructJobInfo(activity, 5000000, extras);
263+
JobInfo jobInfo = DownloadMediaService.constructJobInfo(activity, 5000000, imgurMedia);
270264
((JobScheduler) activity.getSystemService(Context.JOB_SCHEDULER_SERVICE)).schedule(jobInfo);
271265

272266
Toast.makeText(activity, R.string.download_started, Toast.LENGTH_SHORT).show();

0 commit comments

Comments
 (0)