Skip to content

Commit ffe6083

Browse files
authored
Merge pull request #35 from EducationalTestingService/hotfix/fix-fit-method
HotFix: Add `self` to `fit()` method in CFA
2 parents 408efe1 + 51950da commit ffe6083

File tree

4 files changed

+14
-13
lines changed

4 files changed

+14
-13
lines changed

conda-recipe/factor_analyzer/meta.yaml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,18 +21,18 @@ build:
2121

2222
requirements:
2323
build:
24-
- python ==3.6
24+
- python==3.6
2525
- setuptools
2626
- pandas
27-
- scipy=1.2.1
28-
- numpy=1.16.2
29-
- scikit-learn=0.20.1
27+
- scipy
28+
- numpy
29+
- scikit-learn
3030
run:
3131
- python==3.6
3232
- pandas
33-
- scipy=1.2.1
34-
- numpy=1.16.2
35-
- scikit-learn=0.20.1
33+
- scipy
34+
- numpy
35+
- scikit-learn
3636

3737
test:
3838
imports:

conda_requirements.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
python>=3.4
22
pandas
3-
scipy=1.2.1
4-
numpy=1.16.2
5-
scikit-learn=0.20.1
3+
scipy
4+
numpy
5+
scikit-learn
66
nose=1.3.7

factor_analyzer/confirmatory_factor_analyzer.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -757,6 +757,7 @@ def fit(self, X, y=None):
757757
self.aic_ = 2 * res.fun + 2 * (x0.shape[0] + self.model.n_variables)
758758
if self.n_obs is not None:
759759
self.bic_ = 2 * res.fun + np.log(self.n_obs) * (x0.shape[0] + self.model.n_variables)
760+
return self
760761

761762
def transform(self, X):
762763
"""

requirements.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
pandas
2-
scipy==1.2.1
3-
numpy==1.16.2
4-
scikit-learn==0.20.1
2+
scipy
3+
numpy
4+
scikit-learn

0 commit comments

Comments
 (0)