From fac5c1b3e98f199b49b1d125f89e9e5fbdad62d4 Mon Sep 17 00:00:00 2001 From: EpocDotFr Date: Thu, 2 Jul 2020 18:56:04 +0200 Subject: [PATCH 1/6] Add comment --- js/content.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/js/content.js b/js/content.js index c0515aa..c8f632c 100644 --- a/js/content.js +++ b/js/content.js @@ -580,6 +580,9 @@ }).trim(); } + /** + * Add the menu allowing to hide Merge Requests by pipeline statuses. + */ addHideMrsByPipelineStatusMenu() { let menu = '
' + '
' + From 322e532b996605d57c7f5bc70fe62b2b441e4bea Mon Sep 17 00:00:00 2001 From: EpocDotFr Date: Mon, 20 Jul 2020 23:13:24 +0200 Subject: [PATCH 2/6] Move to flex --- css/options.css | 8 ++++---- html/options.html | 10 +++++----- js/options.js | 12 ++++++------ 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/css/options.css b/css/options.css index 4bcc9ca..98f3db0 100644 --- a/css/options.css +++ b/css/options.css @@ -85,12 +85,12 @@ body.is-chrome { * Layout styles */ .row { - display: table; - width: 100%; + display: flex; + flex-direction: row; } -.row > * { - display: table-cell; +.row > .fluid { + flex-grow: 1; } /************************************************************************ diff --git a/html/options.html b/html/options.html index 958543d..1255f54 100644 --- a/html/options.html +++ b/html/options.html @@ -10,7 +10,7 @@
-
+
@@ -21,7 +21,7 @@
-
+
@@ -37,7 +37,7 @@
-
+
@@ -55,7 +55,7 @@
-
+
@@ -66,7 +66,7 @@
-
+
diff --git a/js/options.js b/js/options.js index 3c67a0e..fa78b95 100644 --- a/js/options.js +++ b/js/options.js @@ -38,7 +38,7 @@ this.enableButtonToToggleWipStatusCheckbox = document.querySelector('input#enable_button_to_toggle_wip_status'); - this.enableMenuToHideMrsBasedOnPipelineStatus = document.querySelector('input#enable_menu_to_hide_mrs_based_on_pipeline_status'); + this.enableMenuToHideMrsBasedOnPipelineStatusCheckbox = document.querySelector('input#enable_menu_to_hide_mrs_based_on_pipeline_status'); } /** @@ -70,8 +70,8 @@ self.enableButtonToToggleWipStatusCheckbox.checked = preferences.enable_button_to_toggle_wip_status; self.enableButtonToToggleWipStatusCheckbox.dispatchEvent(new CustomEvent('change')); - self.enableMenuToHideMrsBasedOnPipelineStatus.checked = preferences.enable_menu_to_hide_mrs_based_on_pipeline_status; - self.enableMenuToHideMrsBasedOnPipelineStatus.dispatchEvent(new CustomEvent('change')); + self.enableMenuToHideMrsBasedOnPipelineStatusCheckbox.checked = preferences.enable_menu_to_hide_mrs_based_on_pipeline_status; + self.enableMenuToHideMrsBasedOnPipelineStatusCheckbox.dispatchEvent(new CustomEvent('change')); }); } @@ -123,7 +123,7 @@ self.forceUserToEnableAtLeastOneFeatureIfNecessarily(); }); - this.enableMenuToHideMrsBasedOnPipelineStatus.addEventListener('change', function() { + this.enableMenuToHideMrsBasedOnPipelineStatusCheckbox.addEventListener('change', function() { self.forceUserToEnableAtLeastOneFeatureIfNecessarily(); }); } @@ -148,7 +148,7 @@ base_jira_url: this.baseJiraUrlInput.value, jira_ticket_link_label_type: jira_ticket_link_label_type, enable_button_to_toggle_wip_status: this.enableButtonToToggleWipStatusCheckbox.checked, - enable_menu_to_hide_mrs_based_on_pipeline_status: this.enableMenuToHideMrsBasedOnPipelineStatus.checked + enable_menu_to_hide_mrs_based_on_pipeline_status: this.enableMenuToHideMrsBasedOnPipelineStatusCheckbox.checked }, function() { self.setSuccessfulVisualFeedbackOnSubmitButton(); @@ -184,7 +184,7 @@ && !this.enableButtonToCopyMrInfoCheckbox.checked && !this.enableJiraTicketLinkCheckbox.checked && !this.enableButtonToToggleWipStatusCheckbox.checked - && !this.enableMenuToHideMrsBasedOnPipelineStatus.checked; + && !this.enableMenuToHideMrsBasedOnPipelineStatusCheckbox.checked; } /** From 5db0de6782531f916bace8bb8333079b88db468d Mon Sep 17 00:00:00 2001 From: EpocDotFr Date: Thu, 10 Sep 2020 13:35:04 +0200 Subject: [PATCH 3/6] Enable the feature --- html/options.html | 4 ++-- js/content.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/html/options.html b/html/options.html index 1f0ac52..1255f54 100644 --- a/html/options.html +++ b/html/options.html @@ -62,7 +62,7 @@
This feature is automatically disabled if logged-out
- +
diff --git a/js/content.js b/js/content.js index 5a74dad..c8f632c 100644 --- a/js/content.js +++ b/js/content.js @@ -189,7 +189,7 @@ * Determines if the project do uses the Gitlab "pipeline" feature. */ isPipelineFeatureEnabled() { - return false;// document.querySelector('.nav-sidebar .shortcuts-pipelines') ? true : false; + return document.querySelector('.nav-sidebar .shortcuts-pipelines') ? true : false; } /** From 9719ce7939c2c395602536163183ec671d65219a Mon Sep 17 00:00:00 2001 From: EpocDotFr Date: Thu, 10 Sep 2020 20:19:51 +0200 Subject: [PATCH 4/6] Revert --- js/content.js | 3 --- js/options.js | 12 ++++++------ 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/js/content.js b/js/content.js index c8f632c..c0515aa 100644 --- a/js/content.js +++ b/js/content.js @@ -580,9 +580,6 @@ }).trim(); } - /** - * Add the menu allowing to hide Merge Requests by pipeline statuses. - */ addHideMrsByPipelineStatusMenu() { let menu = '
' + '
' + diff --git a/js/options.js b/js/options.js index fa78b95..3c67a0e 100644 --- a/js/options.js +++ b/js/options.js @@ -38,7 +38,7 @@ this.enableButtonToToggleWipStatusCheckbox = document.querySelector('input#enable_button_to_toggle_wip_status'); - this.enableMenuToHideMrsBasedOnPipelineStatusCheckbox = document.querySelector('input#enable_menu_to_hide_mrs_based_on_pipeline_status'); + this.enableMenuToHideMrsBasedOnPipelineStatus = document.querySelector('input#enable_menu_to_hide_mrs_based_on_pipeline_status'); } /** @@ -70,8 +70,8 @@ self.enableButtonToToggleWipStatusCheckbox.checked = preferences.enable_button_to_toggle_wip_status; self.enableButtonToToggleWipStatusCheckbox.dispatchEvent(new CustomEvent('change')); - self.enableMenuToHideMrsBasedOnPipelineStatusCheckbox.checked = preferences.enable_menu_to_hide_mrs_based_on_pipeline_status; - self.enableMenuToHideMrsBasedOnPipelineStatusCheckbox.dispatchEvent(new CustomEvent('change')); + self.enableMenuToHideMrsBasedOnPipelineStatus.checked = preferences.enable_menu_to_hide_mrs_based_on_pipeline_status; + self.enableMenuToHideMrsBasedOnPipelineStatus.dispatchEvent(new CustomEvent('change')); }); } @@ -123,7 +123,7 @@ self.forceUserToEnableAtLeastOneFeatureIfNecessarily(); }); - this.enableMenuToHideMrsBasedOnPipelineStatusCheckbox.addEventListener('change', function() { + this.enableMenuToHideMrsBasedOnPipelineStatus.addEventListener('change', function() { self.forceUserToEnableAtLeastOneFeatureIfNecessarily(); }); } @@ -148,7 +148,7 @@ base_jira_url: this.baseJiraUrlInput.value, jira_ticket_link_label_type: jira_ticket_link_label_type, enable_button_to_toggle_wip_status: this.enableButtonToToggleWipStatusCheckbox.checked, - enable_menu_to_hide_mrs_based_on_pipeline_status: this.enableMenuToHideMrsBasedOnPipelineStatusCheckbox.checked + enable_menu_to_hide_mrs_based_on_pipeline_status: this.enableMenuToHideMrsBasedOnPipelineStatus.checked }, function() { self.setSuccessfulVisualFeedbackOnSubmitButton(); @@ -184,7 +184,7 @@ && !this.enableButtonToCopyMrInfoCheckbox.checked && !this.enableJiraTicketLinkCheckbox.checked && !this.enableButtonToToggleWipStatusCheckbox.checked - && !this.enableMenuToHideMrsBasedOnPipelineStatusCheckbox.checked; + && !this.enableMenuToHideMrsBasedOnPipelineStatus.checked; } /** From 5590a49af50d114bfac5401a2eedc507a1b6c7bd Mon Sep 17 00:00:00 2001 From: EpocDotFr Date: Thu, 10 Sep 2020 20:20:28 +0200 Subject: [PATCH 5/6] Oops --- html/options.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/html/options.html b/html/options.html index 1255f54..1f0ac52 100644 --- a/html/options.html +++ b/html/options.html @@ -62,7 +62,7 @@
This feature is automatically disabled if logged-out
-
+
From d5030731584c543e71ceb9cf91b57f0181847133 Mon Sep 17 00:00:00 2001 From: EpocDotFr Date: Mon, 25 Jan 2021 12:39:31 +0100 Subject: [PATCH 6/6] Oops --- html/options.html | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/html/options.html b/html/options.html index dbc6c19..7d12493 100644 --- a/html/options.html +++ b/html/options.html @@ -63,10 +63,15 @@ This feature is automatically disabled if logged-out
- TODO +
+ +
+
+ +
- This feature is automatically disabled if the GitLab "pipeline" feature is disabled + Note the All discussions must be resolved option must be enabled for this feature to be working as expected. This option is enabled per project and is located in Settings > General > Merge Requests > Merge checks.
TODO