Merge pull request #818 from FFXIV-CombatReborn/venomthrowitback

Hotfix for Viper rework and SGE

Author: LTS-FFXIV

BasicRotations/Healer/SGE_Default.cs

@@ -447,23 +447,23 @@ private bool ChoiceEukrasia(out IAction? act)
 
         // Checks for Eukrasia status.
         // Attempts to set correct Eurkrasia action based on availability and MergedStatus.
-        if (EukrasianPrognosisIiPvE.CanUse(out _) 
-            && EukrasianPrognosisIiPvE.EnoughLevel && MergedStatus.HasFlag(AutoStatus.DefenseArea) && EukrasianPrognosisIiPvE.IsEnabled)
+        if (EukrasianPrognosisIiPvE.EnoughLevel && EukrasianPrognosisIiPvE.IsEnabled && MergedStatus.HasFlag(AutoStatus.DefenseArea)
+            && EukrasianPrognosisIiPvE.CanUse(out _))
         {
             SetEukrasia(EukrasianPrognosisIiPvE);
         }
-        else if (EukrasianPrognosisPvE.CanUse(out _) 
-            && EukrasianPrognosisPvE.EnoughLevel && MergedStatus.HasFlag(AutoStatus.DefenseArea) && EukrasianPrognosisPvE.IsEnabled)
+        else if (!EukrasianPrognosisIiPvE.EnoughLevel && EukrasianPrognosisPvE.EnoughLevel && EukrasianPrognosisPvE.IsEnabled && MergedStatus.HasFlag(AutoStatus.DefenseArea)
+            && EukrasianPrognosisPvE.CanUse(out _))
         {
             SetEukrasia(EukrasianPrognosisPvE);
         }
-        else if (EukrasianDiagnosisPvE.CanUse(out _) 
-            && EukrasianDiagnosisPvE.EnoughLevel && MergedStatus.HasFlag(AutoStatus.DefenseSingle) && EukrasianDiagnosisPvE.IsEnabled)
+        else if (EukrasianDiagnosisPvE.EnoughLevel && EukrasianDiagnosisPvE.IsEnabled && MergedStatus.HasFlag(AutoStatus.DefenseSingle)
+            && EukrasianDiagnosisPvE.CanUse(out _))
         {
             SetEukrasia(EukrasianDiagnosisPvE);
         }
-        else if (EukrasianDyskrasiaPvE.CanUse(out _) 
-            && EukrasianDyskrasiaPvE.EnoughLevel && (!MergedStatus.HasFlag(AutoStatus.DefenseSingle) || !MergedStatus.HasFlag(AutoStatus.DefenseArea)) && EukrasianDyskrasiaPvE.IsEnabled)
+        else if (EukrasianDyskrasiaPvE.EnoughLevel && EukrasianDyskrasiaPvE.IsEnabled && (!MergedStatus.HasFlag(AutoStatus.DefenseSingle) || !MergedStatus.HasFlag(AutoStatus.DefenseArea))
+            && EukrasianDyskrasiaPvE.CanUse(out _))
         {
             SetEukrasia(EukrasianDyskrasiaPvE);
         }

BasicRotations/Melee/VPR_Default.cs

@@ -392,13 +392,15 @@ protected override bool GeneralGCD(out IAction? act)
                     return true;
             }
 
-            if (HuntersCoilPvE.Target.Target != null && CanHitPositional(EnemyPositional.Flank, HuntersCoilPvE.Target.Target) &&
+            var Htarget = HuntersCoilPvE.Target.Target;
+            if (Htarget != null && CanHitPositional(EnemyPositional.Flank, HuntersCoilPvE.Target.Target) &&
                 HuntersCoilPvE.CanUse(out act, skipComboCheck: true))
             {
                 return true;
             }
 
-            if (SwiftskinsCoilPvE.Target.Target != null && CanHitPositional(EnemyPositional.Rear, SwiftskinsCoilPvE.Target.Target) &&
+            var Starget = SwiftskinsCoilPvE.Target.Target;
+            if (Starget != null && CanHitPositional(EnemyPositional.Rear, SwiftskinsCoilPvE.Target.Target) &&
                 SwiftskinsCoilPvE.CanUse(out act, skipComboCheck: true))
             {
                 return true;

RotationSolver.Basic/Helpers/ObjectHelper.cs

@@ -81,6 +81,11 @@ internal static bool HasPositional(this IBattleChara battleChara)
             return false;
         }
 
+        if (battleChara.StatusList == null)
+        {
+            return false;
+        }
+
         if (battleChara.HasStatus(false, StatusID.DirectionalDisregard))
         {
             return false;