Merge pull request #217 from FFXIV-CombatReborn/new-job-role-actions

NostraThomas99 · web-flow · commit 62c5e2e6c70c · 2024-07-12T17:51:23.000-05:00
Allow for PCT/VPR to use role actions
diff --git a/RotationSolver.Basic/Actions/ActionBasicInfo.cs b/RotationSolver.Basic/Actions/ActionBasicInfo.cs
@@ -194,11 +194,6 @@ internal readonly bool BasicCheck(bool skipStatusProvideCheck, bool skipComboChe
             if (!CheckForCombo()) return false;
         }
 
-        if (_action.Action.IsRoleAction)
-        {
-            if (!_action.Action.ClassJobCategory.Value?.IsJobInCategory(DataCenter.Job) ?? false) return false;
-        }
-
         //Need casting.
         if (CastTime > 0 && !player.HasStatus(true, 
             [
diff --git a/RotationSolver.Basic/Helpers/ConfigurationHelper.cs b/RotationSolver.Basic/Helpers/ConfigurationHelper.cs
@@ -19,6 +19,12 @@ internal static class ConfigurationHelper
         {ActionID.GallowsPvE, EnemyPositional.Rear },
         {ActionID.GekkoPvE, EnemyPositional.Rear},
         {ActionID.KashaPvE, EnemyPositional.Flank },
+        {ActionID.FlankstingStrikePvE, EnemyPositional.Flank},
+        {ActionID.FlanksbaneFangPvE, EnemyPositional.Flank},
+        {ActionID.HindstingStrikePvE, EnemyPositional.Rear},
+        {ActionID.HindsbaneFangPvE, EnemyPositional.Rear},
+        {ActionID.HuntersCoilPvE, EnemyPositional.Flank},
+        {ActionID.SwiftskinsCoilPvE, EnemyPositional.Rear}
     };
 
     public static readonly uint[] BadStatus =

Original file line number	Diff line number	Diff line change
`@@ -194,11 +194,6 @@ internal readonly bool BasicCheck(bool skipStatusProvideCheck, bool skipComboChe`
`194`	`194`	`if (!CheckForCombo()) return false;`
`195`	`195`	`}`
`196`	`196`
`197`		`- if (_action.Action.IsRoleAction)`
`198`		`- {`
`199`		`- if (!_action.Action.ClassJobCategory.Value?.IsJobInCategory(DataCenter.Job) ?? false) return false;`
`200`		`- }`
`201`		`-`
`202`	`197`	`//Need casting.`
`203`	`198`	`if (CastTime > 0 && !player.HasStatus(true,`
`204`	`199`	`[`