Skip to content

Commit dc5b3aa

Browse files
authored
Merge pull request #839 from FFXIV-CombatReborn/MNKRework
Monk Rework, SGE hotfix for Zoe, wording fix for healer configs
2 parents 97c86dd + 6baf613 commit dc5b3aa

File tree

6 files changed

+266
-156
lines changed

6 files changed

+266
-156
lines changed

BasicRotations/Healer/AST_Default.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public sealed class AST_Default : AstrologianRotation
1414
[RotationConfig(CombatType.PvE, Name = "Use both stacks of Lightspeed while moving")]
1515
public bool LightspeedMove { get; set; } = true;
1616

17-
[RotationConfig(CombatType.PvE, Name = "Use spells with cast times to heal. (Ignored if you are the only healer in party)")]
17+
[RotationConfig(CombatType.PvE, Name = "Use GCDs to heal. (Ignored if you are the only healer in party)")]
1818
public bool GCDHeal { get; set; } = false;
1919

2020
[RotationConfig(CombatType.PvE, Name = "Prevent actions while you have the bubble mit up")]

BasicRotations/Healer/SCH_Default.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public sealed class SCH_Default : ScholarRotation
6060
[RotationConfig(CombatType.PvE, Name = "Enable Swiftcast restriction: only allow Raise while Swiftcast is active")]
6161
public bool SwiftLogic { get; set; } = true;
6262

63-
[RotationConfig(CombatType.PvE, Name = "Allow use of cast-time spells for healing (ignored if solo healer)")]
63+
[RotationConfig(CombatType.PvE, Name = "Use GCDs to heal. (Ignored if you are the only healer in party)")]
6464
public bool GCDHeal { get; set; } = true;
6565

6666
[RotationConfig(CombatType.PvE, Name = "Use Recitation during the countdown opener")]

BasicRotations/Healer/SGE_Default.cs

Lines changed: 25 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public sealed class SGE_Default : SageRotation
1717
[RotationConfig(CombatType.PvE, Name = "Use Rhizomata when out of combat")]
1818
public bool OOCRhizomata { get; set; } = false;
1919

20-
[RotationConfig(CombatType.PvE, Name = "Use spells with cast times to heal. (Ignored if you are the only healer in party)")]
20+
[RotationConfig(CombatType.PvE, Name = "Use GCDs to heal. (Ignored if you are the only healer in party)")]
2121
public bool GCDHeal { get; set; } = false;
2222

2323
[RotationConfig(CombatType.PvE, Name = "Enable Swiftcast Restriction Logic to attempt to prevent actions other than Raise when you have swiftcast")]
@@ -125,7 +125,30 @@ protected override bool EmergencyAbility(IAction nextGCD, out IAction? act)
125125
return true;
126126
}
127127

128-
//if (base.EmergencyAbility(nextGCD, out act)) return true;
128+
if (ZoePvE.EnoughLevel && !ZoePvE.Cooldown.IsCoolingDown)
129+
{
130+
if (nextGCD.IsTheSameTo(false, PneumaPvE))
131+
{
132+
if (ZoePvE.CanUse(out act))
133+
{
134+
return true;
135+
}
136+
}
137+
138+
if (nextGCD.IsTheSameTo(false, EukrasiaPvE))
139+
{
140+
if (_EukrasiaActionAim == EukrasianPrognosisPvE
141+
|| _EukrasiaActionAim == EukrasianPrognosisIiPvE
142+
|| _EukrasiaActionAim == EukrasianDiagnosisPvE)
143+
{
144+
if (ZoePvE.CanUse(out act))
145+
{
146+
return true;
147+
}
148+
}
149+
}
150+
}
151+
129152

130153
return base.EmergencyAbility(nextGCD, out act);
131154
}
@@ -251,21 +274,6 @@ protected override bool HealSingleAbility(IAction nextGCD, out IAction? act)
251274
IEnumerable<IBattleChara> tankEnum = PartyMembers.GetJobCategory(JobRole.Tank);
252275
List<IBattleChara> tank = [.. tankEnum];
253276

254-
if (nextGCD.IsTheSameTo(false, PneumaPvE, EukrasianPrognosisPvE, EukrasianPrognosisIiPvE))
255-
{
256-
for (int i = 0; i < tank.Count; i++)
257-
{
258-
IBattleChara t = tank[i];
259-
if (t.GetHealthRatio() < ZoeHeal)
260-
{
261-
if (ZoePvE.CanUse(out act))
262-
{
263-
return true;
264-
}
265-
}
266-
}
267-
}
268-
269277
if (nextGCD.IsTheSameTo(false, PneumaPvE, EukrasianDiagnosisPvE, DiagnosisPvE, PrognosisPvE))
270278
{
271279
for (int i = 0; i < tank.Count; i++)

BasicRotations/Healer/WHM_Default.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ public sealed class WHM_Default : WhiteMageRotation
1515
[RotationConfig(CombatType.PvE, Name = "Enable Swiftcast Restriction Logic to attempt to prevent actions other than Raise when you have swiftcast")]
1616
public bool SwiftLogic { get; set; } = true;
1717

18-
[RotationConfig(CombatType.PvE, Name = "Use spells with cast times to heal. (Ignored if you are the only healer in party)")]
19-
public bool GCDHeal { get; set; } = false;
18+
[RotationConfig(CombatType.PvE, Name = "Use GCDs to heal. (Ignored if you are the only healer in party)")]
19+
public bool GCDHeal { get; set; } = true;
2020

2121
[RotationConfig(CombatType.PvE, Name = "Use DOT while moving even if it does not need refresh (disabling is a damage down)")]
2222
public bool DOTUpkeep { get; set; } = true;

0 commit comments

Comments
 (0)