Skip to content

Commit ddd87ac

Browse files
authored
Merge pull request #969 from FFXIV-CombatReborn/starboy
Fix for PCT PvP Star Prism action, added more cycling options for new command
2 parents 6b43d6f + 7bc8276 commit ddd87ac

File tree

6 files changed

+41
-1
lines changed

6 files changed

+41
-1
lines changed

RotationSolver.Basic/Data/CycleType.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,12 @@ public enum CycleType : byte
1717
[Description("Cycle between each Auto, Manual, and Off")]
1818
CycleAllAuto,
1919

20+
/// <summary>
21+
/// Cycle between Auto and Off
22+
/// </summary>
23+
[Description("Cycle between Auto and Off")]
24+
CycleAuto,
25+
2026
/// <summary>
2127
/// Cycle between Manual and Off
2228
/// </summary>

RotationSolver.Basic/Data/DTRType.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,12 @@ public enum DTRType : byte
1717
[Description("Cycle between each Auto, Manual, and Off")]
1818
DTRAllAuto,
1919

20+
/// <summary>
21+
/// Cycle between Auto and Off
22+
/// </summary>
23+
[Description("Cycle between Auto and Off")]
24+
DTRAuto,
25+
2026
/// <summary>
2127
/// Cycle between Manual and Off
2228
/// </summary>

RotationSolver.Basic/Rotations/Basic/PictomancerRotation.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -980,7 +980,7 @@ static partial void ModifyTemperaGrassaPvP(ref ActionSetting setting)
980980

981981
static partial void ModifyStarPrismPvP(ref ActionSetting setting)
982982
{
983-
setting.StatusNeed = [StatusID.StarPrism];
983+
setting.StatusNeed = [StatusID.Starstruck_4118];
984984
setting.MPOverride = () => 0;
985985
setting.StatusProvide = [StatusID.StarPrism];
986986
setting.CreateConfig = () => new ActionConfig()

RotationSolver/Commands/RSCommands_OtherCommand.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,10 @@ private static void ExecuteCycleCommand()
5353
{
5454
CycleStateWithAllTargetTypes();
5555
}
56+
else if (Service.Config.CycleType == CycleType.CycleAuto)
57+
{
58+
CycleStateAuto();
59+
}
5660
else if (Service.Config.CycleType == CycleType.CycleManual)
5761
{
5862
CycleStateManual();

RotationSolver/Commands/RSCommands_StateSpecialCommand.cs

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,26 @@ public static void CycleStateManualAuto()
100100
DoStateCommandType(StateCommandType.Manual);
101101
}
102102

103+
public static void CycleStateAuto()
104+
{
105+
// If currently Off, go to Auto
106+
if (!DataCenter.State)
107+
{
108+
DoStateCommandType(StateCommandType.Auto);
109+
return;
110+
}
111+
112+
// If currently in Auto mode, turn Off
113+
if (DataCenter.State)
114+
{
115+
DoStateCommandType(StateCommandType.Off);
116+
return;
117+
}
118+
119+
// If currently On but not Auto, switch to Auto
120+
DoStateCommandType(StateCommandType.Manual);
121+
}
122+
103123
public static void CycleStateManual()
104124
{
105125
// If currently Off, go to Manual

RotationSolver/Updaters/MiscUpdater.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,10 @@ internal static void UpdateEntry()
6060
{
6161
_dtrEntry.OnClick = _ => RSCommands.CycleStateWithAllTargetTypes();
6262
}
63+
else if (Service.Config.DTRType == DTRType.DTRAuto)
64+
{
65+
_dtrEntry.OnClick = _ => RSCommands.CycleStateAuto();
66+
}
6367
else if (Service.Config.DTRType == DTRType.DTRManual)
6468
{
6569
_dtrEntry.OnClick = _ => RSCommands.CycleStateManual();

0 commit comments

Comments
 (0)