Skip to content

Commit a363e46

Browse files
committed
test: add Aqua and fix errors
- Fix method ambiguity for `integrated_interaction`. - Fix compat entries.
1 parent 6a79609 commit a363e46

File tree

4 files changed

+12
-2
lines changed

4 files changed

+12
-2
lines changed

Project.toml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,19 @@ RecursiveArrayTools = "731186ca-8d62-57ce-b412-fbd966d074cd"
1212
SpecialFunctions = "276daf66-3868-5448-9aa4-cd146d93841b"
1313

1414
[compat]
15+
Aqua = "0.8"
1516
DocStringExtensions = "0.9"
1617
RecipesBase = "1"
1718
RecursiveArrayTools = "2, 3"
1819
SpecialFunctions = "2"
20+
Test = "1"
21+
TestSetExtensions = "2, 3"
1922
julia = "1.4"
2023

2124
[extras]
25+
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
2226
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
2327
TestSetExtensions = "98d24dd4-01ad-11ea-1b02-c9a08f80db04"
2428

2529
[targets]
26-
test = ["Test", "TestSetExtensions"]
30+
test = ["Aqua", "Test", "TestSetExtensions"]

src/interactions.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ See also [`sampled_interaction`](@ref), [`compute_interaction`](@ref).
4949
"""
5050
function integrated_interaction end
5151

52-
function integrated_interaction(x::Real, W, ys::AbstractVector{<:Real}, dens_diff::AbstractVector{<:Real}=diff(pwc_density(ys)))
52+
function integrated_interaction(x::Real, W::Function, ys::AbstractVector{<:Real}, dens_diff::AbstractVector{<:Real}=diff(pwc_density(ys)))
5353
# eachindex(dens_diff) == eachindex(ys) || throw(DimensionMismatch("`ys` and `dens_diff` must have the same indices"))
5454
# -sum(i -> (@inbounds W(x - ys[i]) * dens_diff[i]), eachindex(ys, dens_diff))
5555
-sum(p -> W(x - p[1]) * p[2], zip(ys, dens_diff))

test/Aqua.jl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
@testset "Aqua tests" begin
2+
import Aqua
3+
Aqua.test_all(ConservationLawsParticles)
4+
end

test/runtests.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ using RecursiveArrayTools
33
using Test
44
using TestSetExtensions
55

6+
include("Aqua.jl")
7+
68
@testset ExtendedTestSet "ConservationLawsParticles.jl" begin
79
@testset "densities" begin
810
include("test_densities.jl")

0 commit comments

Comments
 (0)