More refactoring

Author: Ralkage

js/dist/forum.js

@@ -11,11 +11,12 @@ export default function () {
 
   extend(DiscussionList.prototype, 'sortMap', function (map) {
 
-    // Delete map.latest;
+    // Delete Mapping
     delete map.top;
     delete map.newest;
     delete map.oldest;
 
+    // Re-Add Mapping to Redo Sort Order
     map.front = '-frontdate';
     map.top = '-commentCount';
     map.newest = '-createdAt';

js/dist/forum.js.map

@@ -9,7 +9,7 @@ export default function addStickyBadge() {
   extend(Discussion.prototype, 'badges', function(badges) {
     if (this.frontpage()) {
       badges.add('frontpage', Badge.component({
-        type: 'front',
+        type: 'frontpage',
         label: app.translator.trans('core.forum.badge.frontpage_tooltip'),
         icon: 'fas fa-home'
       }), 10);

js/src/forum/addFrontSort.js

@@ -1,13 +1,7 @@
-.Badge--front {
+.Badge--frontpage {
   background: #7fba00;
 }
-.DiscussionStickiedPost {
-  & .EventPost-icon,
-  & .EventPost-info,
-  & .EventPost-info a {
-    color: #7fba00;
-  }
-}
+
 .DiscussionListItem-info .item-excerpt {
   margin-top: 8px;
   margin-right: 20px;

js/src/forum/addStickyBadge.js

@@ -10,4 +10,3 @@ core:
   admin:
     permissions:
       can_push_to_frontpage_label: Can Push to FrontPage
-

resources/less/forum.less

@@ -42,8 +42,6 @@ public function whenDiscussionWillBeSaved(Saving $event)
             if ((bool)$discussion->frontpage === $front) {
                 return;
             }
-            $attributes = array_get($event->data, 'attributes', []);
-
             $discussion->frontdate = new DateTime();
 
             $discussion->frontpage = $front;