-
-
Notifications
You must be signed in to change notification settings - Fork 841
Closed
Description
In the main script, githubuser
defaults to GameServerManagers
(plural):
Line 50 in 6b73179
[ -n "${LGSM_GITHUBUSER}" ] && githubuser="${LGSM_GITHUBUSER}" || githubuser="GameServerManagers" |
But then githubuser
is compared to GameServerManager
(non-plural):
Lines 170 to 177 in 6b73179
# If master branch will currently running LinuxGSM version to prevent "version mixing". This is ignored if a fork. | |
if [ "${githubbranch}" == "master" ] && [ "${githubuser}" == "GameServerManager" ] && [ "${commandname}" != "UPDATE-LGSM" ]; then | |
remote_fileurl="https://raw.githubusercontent.com/${githubuser}/${githubrepo}/${version}/${github_file_url_dir}/${github_file_url_name}" | |
remote_fileurl_backup="https://bitbucket.org/${githubuser}/${githubrepo}/raw/${version}/${github_file_url_dir}/${github_file_url_name}" | |
else | |
remote_fileurl="https://raw.githubusercontent.com/${githubuser}/${githubrepo}/${githubbranch}/${github_file_url_dir}/${github_file_url_name}" | |
remote_fileurl_backup="https://bitbucket.org/${githubuser}/${githubrepo}/raw/${githubbranch}/${github_file_url_dir}/${github_file_url_name}" | |
fi |
This seems to be a trend throughout the codebase: https://github.com/GameServerManagers/LinuxGSM/search?q=gameservermanager+githubuser
Metadata
Metadata
Assignees
Labels
type: bugSomething isn't workingSomething isn't working
Type
Projects
Status
✅ Done