Skip to content

Commit 9323b9a

Browse files
Merge pull request #17 from GeorgeDavis-Ibexlabs/dev
Merge changes in `dev` to `main`
2 parents a257ff5 + 54ec951 commit 9323b9a

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

.github/workflows/docker-publish.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -55,18 +55,18 @@ jobs:
5555
- name: Update Docker Hub description
5656
uses: peter-evans/dockerhub-description@v4.0.0
5757
with:
58-
username: ${{ secrets.DOCKERHUB_USERNAME }}
59-
password: ${{ secrets.DOCKERHUB_TOKEN }}
60-
repository: georgedavisibexlabs/publish-sarif-to-jira
61-
short-description: Publish SARIF data to JIRA
62-
readme-filepath: ./DOCKER.md
63-
enable-url-completion: true
58+
username: ${{ secrets.DOCKERHUB_USERNAME }}
59+
password: ${{ secrets.DOCKERHUB_TOKEN }}
60+
repository: georgedavisibexlabs/publish-sarif-to-jira
61+
short-description: Publish SARIF data to JIRA
62+
readme-filepath: ./DOCKER.md
63+
enable-url-completion: true
6464

6565
- name: Run Trivy Image scanner
6666
uses: aquasecurity/trivy-action@0.24.0
6767
with:
6868
scan-type: 'image'
69-
image-ref: 'georgedavisibexlabs/publish-sarif-to-jira'
69+
image-ref: 'georgedavisibexlabs/publish-sarif-to-jira:main'
7070
limit-severities-for-sarif: true
7171
trivy-config: .github/config/trivy-sarif.yaml
7272

main.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,14 @@ def main():
5757

5858
sarif_tool_name, sarif_data = sarifObj.load_sarif_data(sarif_file_path=sarif_file_path)
5959

60-
logger.info("[" + sarif_tool_name + "]: Total no. of issues found in SARIF report - " + str(sarif_data.get_result_count()))
60+
sarif_result_count = sarif_data.get_result_count()
6161

62-
if sarif_data.get_result_count() > 0:
62+
logger.info("[" + sarif_tool_name + "]: Total no. of issues found in SARIF report - " + str(sarif_result_count))
6363

64+
if sarif_result_count == 0:
65+
logger.error("[" + sarif_tool_name + "]: No results found.")
66+
67+
else:
6468
sarif_findings = sarifObj.build_sarif_findings_dict(
6569
sarif_tool_name=sarif_tool_name,
6670
sarif_data=sarif_data
@@ -121,8 +125,6 @@ def main():
121125
issue_desc = issue_desc,
122126
issue_type = "Task"
123127
)
124-
else:
125-
logger.error("[" + sarif_tool_name + "]: No results found.")
126128

127129
logger.info("Success.")
128130

0 commit comments

Comments
 (0)