Skip to content

Commit 46ffda4

Browse files
authored
Merge pull request #70 from HPI-Information-Systems/develop
Release v1.1.1
2 parents 2b6a2b0 + 51fcdef commit 46ffda4

File tree

20 files changed

+210
-18
lines changed

20 files changed

+210
-18
lines changed

app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "snowman-app",
33
"author": "Snowman Team",
44
"description": "Compare data matching algorithms with each other",
5-
"version": "1.1.0",
5+
"version": "1.1.1",
66
"license": "MIT",
77
"homepage": "./",
88
"dependencies": {

app/src/api/apis/ExperimentsApi.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,5 +341,7 @@ export enum SetExperimentFileFormatEnum {
341341
Magellan = 'magellan',
342342
ClusterEr = 'clusterER',
343343
Pilot = 'pilot',
344-
Sigmod2021 = 'sigmod2021'
344+
Sigmod2021 = 'sigmod2021',
345+
Bhana = 'BHANA',
346+
Bpies = 'BPIES'
345347
}

app/src/components/PageStruct/PageStruct.View.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ const PageStructView = ({
2929
</IonButtons>
3030
<IonTitle>{title}</IonTitle>
3131
<div slot="end" className="spinner-container">
32-
{showIndicator ? <IonSpinner color="light" /> : null}
32+
{showIndicator ? <IonSpinner className="spinner-white" /> : null}
3333
</div>
3434
</IonToolbar>
3535
</IonHeader>
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
11
.spinner-container {
22
margin-right: 15px;
33
}
4+
5+
.spinner-white {
6+
color: #fff !important;
7+
}

app/src/pages/DatasetsPage/DatasetsPage.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ const mapStateToProps = (state: Store): DatasetsPageStateProps => ({
3434
description: aDataset.description,
3535
subtitle: (aDataset?.tags ?? []).join(', ').toUpperCase(),
3636
tags: [
37-
`Total: ${aDataset.numberOfRecords}`,
38-
`Uploaded: ${aDataset.numberOfUploadedRecords}`,
37+
`Total: ${aDataset.numberOfRecords ?? 'unknown'}`,
38+
`Uploaded: ${aDataset.numberOfUploadedRecords ?? 'none'}`,
3939
],
4040
})
4141
),

app/src/store/actions/DatasetsStoreActions.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import {
1313
easyPrimitiveActionReturn,
1414
} from 'utils/easyActionsFactory';
1515
import RequestHandler from 'utils/requestHandler';
16+
import { SUCCESS_DELETE_DATASET } from 'utils/statusMessages';
1617

1718
export const clickOnDataset = (
1819
aDatasetId: number
@@ -77,6 +78,7 @@ export const deleteDataset = (
7778
dispatch(resetSelectedDataset());
7879
return RequestHandler(
7980
(): Promise<void> => new DatasetsApi().deleteDataset({ datasetId: id }),
80-
dispatch
81+
dispatch,
82+
SUCCESS_DELETE_DATASET
8183
).then((): Promise<void> => dispatch(getDatasets()));
8284
};

app/src/store/actions/ExperimentDialogStoreActions.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -177,19 +177,23 @@ const addNewExperiment = (): SnowmanThunkAction<Promise<void>> => async (
177177
): Promise<void> => {
178178
dispatch(createNewExperiment())
179179
.then((id: number): Promise<void> => dispatch(uploadExperimentFile(id)))
180-
.then((): Promise<void> => dispatch(getExperiments()))
181180
.then((): void => dispatch(resetDialog()))
182-
.finally((): void => dispatch(closeDialog()));
181+
.finally((): void => {
182+
dispatch(getExperiments());
183+
dispatch(closeDialog());
184+
});
183185
};
184186

185187
const updateExistingExperiment = (): SnowmanThunkAction<
186188
Promise<void>
187189
> => async (dispatch: SnowmanDispatch): Promise<void> => {
188190
dispatch(editExistingExperiment())
189191
.then((): Promise<void> => dispatch(uploadExperimentFile()))
190-
.then((): Promise<void> => dispatch(getExperiments()))
191192
.then((): void => dispatch(resetDialog()))
192-
.finally((): void => dispatch(closeDialog()));
193+
.finally((): void => {
194+
dispatch(getExperiments());
195+
dispatch(closeDialog());
196+
});
193197
};
194198

195199
export const addOrUpdateExperiment = (): SnowmanThunkAction<

app/src/store/actions/ExperimentsStoreActions.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {
1010
easyPrimitiveActionReturn,
1111
} from 'utils/easyActionsFactory';
1212
import RequestHandler from 'utils/requestHandler';
13+
import { SUCCESS_DELETE_EXPERIMENT } from 'utils/statusMessages';
1314

1415
export const clickOnExperimentTag = (aTag: string): easyPrimitiveActionReturn =>
1516
easyPrimitiveAction({
@@ -59,6 +60,7 @@ export const deleteExperiment = (
5960
return RequestHandler(
6061
(): Promise<void> =>
6162
new ExperimentsApi().deleteExperiment({ experimentId: id }),
62-
dispatch
63+
dispatch,
64+
SUCCESS_DELETE_EXPERIMENT
6365
).then((): Promise<void> => dispatch(getExperiments()));
6466
};

app/src/utils/statusMessages.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,5 @@ export const SUCCESS_TO_UPDATE_DATASET =
2222
'Successfully updated the designated dataset!';
2323
export const SUCCESS_TO_UPDATE_EXPERIMENT =
2424
'Successfully updated the designated experiment!';
25+
export const SUCCESS_DELETE_DATASET = 'Successfully deleted the dataset!';
26+
export const SUCCESS_DELETE_EXPERIMENT = 'Successfully deleted the experiment!';

docs/api_specification.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -453,6 +453,8 @@ paths:
453453
- clusterER
454454
- pilot
455455
- sigmod2021
456+
- BHANA
457+
- BPIES
456458
required: true
457459
requestBody:
458460
content:

0 commit comments

Comments
 (0)