Fixes #617 - Building retrofit fails with local building dataset because the dataset id is a path for local datasets (#669)

Co-authored-by: Chen Wang <cwang138@illinois.edu>

Author: navarroc

CHANGELOG.md

@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Added
 - ML Enabled Galveston CGE [#641](https://github.com/IN-CORE/pyincore/issues/641)
+- Add ML enabled Seaside CGE [#657](https://github.com/IN-CORE/pyincore/issues/657)
 
 ### Changed
 - Descriptions of the analyses to be more verbose. [#645](https://github.com/IN-CORE/pyincore/issues/645)
@@ -18,8 +19,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Descriptions of the analyses to be more verbose. [#647](https://github.com/IN-CORE/pyincore/issues/647)
 - Hazard service earthquake post method to allow user to specify soil type dataset [#654](https://github.com/IN-CORE/pyincore/issues/654)
 
-### Added
-- Add ML enabled Seaside CGE [#657](https://github.com/IN-CORE/pyincore/issues/657)
+### Fixed
+- Building retrofit fails with local building dataset. [#617](https://github.com/IN-CORE/pyincore/issues/617)
 
 
 ## [1.21.0] - 2025-02-12

pyincore/utils/datasetutil.py

@@ -13,6 +13,7 @@
 # for evaluation of retrofit expression
 import math  # noqa: F401
 import scipy  # noqa: F401
+import os
 
 
 class DatasetUtil:
@@ -196,7 +197,12 @@ def _apply_retrofit_value(row):
 
             # save the updated inventory to a new shapefile
             tmpdirname = tempfile.mkdtemp()
-            file_path = f"{tmpdirname}/tmp_updated_{inventory_dataset.id}.shp"
+
+            inventory_dataset_id = inventory_dataset.id
+            # Check if inventory ID is a file path and if it is, just use the base name
+            if os.path.isdir(inventory_dataset_id):
+                inventory_dataset_id = os.path.basename(inventory_dataset_id)
+            file_path = f"{tmpdirname}/tmp_updated_{inventory_dataset_id}.shp"
             inventory_df.to_file(file_path)
 
             # return the updated inventory dataset in geoDataframe for future consumption