credentials in test, exceptions pylintrc

Author: marcomelloni

agents/matlab/.pylintrc

@@ -577,11 +577,4 @@ max-returns=6
 max-statements=50
 
 # Minimum number of public methods for a class (see R0903).
-min-public-methods=1
-
-
-[EXCEPTIONS]
-
-# Exceptions that will emit a warning when being caught. Defaults to
-# "BaseException, Exception".
-overgeneral-exceptions=builtins.BaseException,builtins.Exception
+min-public-methods=1

agents/matlab/matlab_agent/resources/use_matlab_agent.py

@@ -223,7 +223,8 @@ def start_listener(agent_identifier: str) -> None:
         # Send the simulation request to the Matlab agent via RabbitMQ.
         client.send_request(simulation_data)
 
-        # Keep the main thread alive to continue receiving asynchronous results.
+        # Keep the main thread alive to continue receiving asynchronous
+        # results.
         print("\nPress Ctrl+C to terminate the program...")
         while True:
             pass

agents/matlab/matlab_agent/src/core/batch.py

@@ -95,7 +95,12 @@ def handle_batch_simulation(
         logger.info("Simulation '%s' completed successfully", sim_file)
 
     except Exception as e:  # pylint: disable=broad-except
-        _handle_error(e, sim_file, rabbitmq_manager, source, response_templates)
+        _handle_error(
+            e,
+            sim_file,
+            rabbitmq_manager,
+            source,
+            response_templates)
     finally:
         # Always complete the operation to record metrics
         performance_monitor.complete_operation()

agents/matlab/matlab_agent/src/core/interactive.py

@@ -61,7 +61,8 @@ def accept(self) -> None:
             self._conn, _ = self._srv.accept()
             self._conn.setblocking(False)
         else:
-            logger.error("[INTERACTIVE] Timeout waiting for client connection.")
+            logger.error(
+                "[INTERACTIVE] Timeout waiting for client connection.")
             raise TimeoutError("No client connection received in time.")
 
     def send(self, data: Dict[str, Any]) -> None:
@@ -203,7 +204,9 @@ def _only_inputs(frame: Dict[str, Any]) -> Dict[str, Any]:
         if isinstance(frame, dict):
             sim = frame.get("simulation")
             if isinstance(sim, dict) and "inputs" in sim:
-                logger.debug("[INTERACTIVE] Received inputs: %s", sim["inputs"])
+                logger.debug(
+                    "[INTERACTIVE] Received inputs: %s",
+                    sim["inputs"])
                 return sim["inputs"]
         return frame
 

agents/matlab/matlab_agent/src/utils/config_manager.py

@@ -219,7 +219,8 @@ def from_dict(cls, config_dict: Dict[str, Any]) -> 'Config':
         if tcp := config_dict.get("tcp", {}):
             flat_config["tcp_input_host"] = tcp.get("input_host", "localhost")
             flat_config["tcp_input_port"] = tcp.get("input_port", 5679)
-            flat_config["tcp_output_host"] = tcp.get("output_host", "localhost")
+            flat_config["tcp_output_host"] = tcp.get(
+                "output_host", "localhost")
             flat_config["tcp_output_port"] = tcp.get("output_port", 5678)
 
         # Extract response_templates section if present

agents/matlab/matlab_agent/src/utils/performance_monitor.py

@@ -256,7 +256,8 @@ def get_summary(self) -> Dict[str, float]:
 
         startup_times = [
             m.matlab_startup_duration for m in self.metrics_history]
-        simulation_times = [m.simulation_duration for m in self.metrics_history]
+        simulation_times = [
+            m.simulation_duration for m in self.metrics_history]
         total_times = [m.total_duration for m in self.metrics_history]
 
         return {

agents/matlab/matlab_agent/test/config/credentials.yaml.tests

@@ -1,3 +1,5 @@
 rabbitmq:
+    host: localhost
+    port: 5672
     username: guest
     password: guest

agents/matlab/matlab_agent/test/unit/test_config_loader.py

@@ -39,16 +39,23 @@ def sample_config_dict(dummy_credentials):
 
 
 @pytest.fixture
-def sample_yaml_content():
+def sample_yaml_content(dummy_credentials):
     """Return sample YAML content for testing."""
-    return """
+    rabbit_creds = dummy_credentials.get("rabbitmq", {})
+
+    host = rabbit_creds.get("host", "localhost")
+    port = rabbit_creds.get("port", 5672)
+    username = rabbit_creds.get("username", "guest")
+    password = rabbit_creds.get("password", "guest")
+
+    return f"""
     agent:
       agent_id: matlab
     rabbitmq:
-      host: "${HOSTNAME:localhost}"
-      port: 5672
-      username: "${USERNAME:xxxx}"
-      password: "${PASSWORD:xxxx}"
+      host: "{host}"
+      port: {port}
+      username: "{username}"
+      password: "{password}"
     nested:
       deep:
         value: 42

agents/matlab/matlab_agent/test/unit/test_logger.py

@@ -69,7 +69,8 @@ def test_setup_logger_default_parameters(self):
             self.assertIsInstance(logger, logging.Logger)
             self.assertEqual(logger.name, self.logger_name)
             self.assertEqual(logger.level, DEFAULT_LOG_LEVEL)
-            self.assertEqual(len(logger.handlers), 2)  # File + Console handlers
+            # File + Console handlers
+            self.assertEqual(len(logger.handlers), 2)
 
             # Close handlers before removing temp directory
             for handler in logger.handlers[:]:
@@ -105,7 +106,8 @@ def test_log_file_creation(self):
         )
 
         self.assertTrue(os.path.exists(log_dir))
-        # Log file might not exist until first write, but directory should exist
+        # Log file might not exist until first write, but directory should
+        # exist
 
     def test_file_handler_configuration(self):
         """Test file handler configuration."""

agents/matlab/matlab_agent/test/unit/test_main.py

@@ -112,7 +112,8 @@ def test_main_with_config_file(self, cli_runner, mock_dependencies):
             'logging': {'level': 'INFO', 'file': 'agent.log'}
         }
 
-        config_path = Path('matlab_agent/config/config.yaml.template').resolve()
+        config_path = Path(
+            'matlab_agent/config/config.yaml.template').resolve()
         result = cli_runner.invoke(main, ['-c', str(config_path)])
 
         mock_load_config.assert_called_once_with(str(config_path))
@@ -512,7 +513,8 @@ def test_cli_short_config_option(self, cli_runner, mock_dependencies):
             'logging': {'level': 'INFO', 'file': 'test.log'}
         }
 
-        config_path = Path('matlab_agent/config/config.yaml.template').resolve()
+        config_path = Path(
+            'matlab_agent/config/config.yaml.template').resolve()
         result = cli_runner.invoke(main, ['-c', str(config_path)])
 
         mock_load_config.assert_called_once_with(str(config_path))