sonarqube issues

Author: marcomelloni

agents/matlab/matlab_agent/src/comm/rabbitmq/message_handler.py

@@ -57,14 +57,14 @@ def validate_sim_type(cls, v):
     @model_validator(mode='after')
     def check_stream_source_for_interactive(self):
         """
-        Validate that 'inputs.stream_source' is provided for interactive simulations.
+        Validate that 'inputs.stream_source' is provided
+        for interactive simulations.
         """
-        if self.type == 'interactive':
-            if not self.inputs.stream_source:
-                raise ValueError(
-                    "For 'interactive' simulations you must provide "
-                    "'inputs.stream_source'"
-                )
+        if self.type == 'interactive' and not self.inputs.stream_source:
+            raise ValueError(
+                "For 'interactive' simulations you must provide "
+                "'inputs.stream_source'"
+            )
         return self
 
 

agents/matlab/matlab_agent/src/core/interactive.py

@@ -34,7 +34,7 @@ def _parse_frame(body: bytes) -> Dict[str, Any]:
     """Decode a YAML frame received from RabbitMQ."""
     try:
         return yaml.safe_load(body)
-    except Exception as exc:  # pragma: no cover - logging only
+    except yaml.YAMLError as exc:  # pragma: no cover - logging only
         logger.error("[INTERACTIVE] Bad frame: %s", exc)
         return {}
 
@@ -243,14 +243,14 @@ def run(self, pm: PerformanceMonitor, msg_dict: Dict[str, Any]) -> None:
                 if self.out_srv.matlab_proc and self.out_srv.matlab_proc.poll() is not None:
                     logger.debug("[INTERACTIVE] MATLAB process ended, stopping loop")
                     break
-                method, properties, body = ch.basic_get(
+                method, _ , body = ch.basic_get(
                     queue=qname, auto_ack=True)
                 while method:
                     frame = _parse_frame(body)
                     if frame:
                         # Send the inputs to MATLAB
                         self.in_srv.send(self._only_inputs(frame))
-                    method, properties, body = ch.basic_get(
+                    method, _ , body = ch.basic_get(
                         queue=qname, auto_ack=True)
 
                 # Receive Responses from MATLAB
@@ -308,8 +308,8 @@ def handle_interactive_simulation(
     try:
         controller.start(pm)
         controller.run(pm, msg_dict)
-    except (KeyError, ValueError, RuntimeError) as exc:  # pragma: no cover - handled errors
-        logger.error("[INTERACTIVE] Fatal: %s", exc)
+    except (KeyError, ValueError) as exc:  # Handle specific known errors
+        logger.error("[INTERACTIVE] Known error: %s", exc)
         rabbitmq_manager.send_result(
             source,
             create_response(

agents/matlab/matlab_agent/test/unit/test_main.py

@@ -10,7 +10,7 @@
 
 import logging
 from pathlib import Path
-from unittest.mock import MagicMock, patch, mock_open, call
+from unittest.mock import MagicMock, patch, mock_open
 import pytest
 from click.testing import CliRunner
 
@@ -105,7 +105,7 @@ def test_generate_project_flag(self, cli_runner):
     # Test main function with config file
     def test_main_with_config_file(self, cli_runner, mock_dependencies):
         """Test main function with explicitly provided config file."""
-        mock_matlab_agent, mock_setup_logger, mock_load_config, mock_logger = mock_dependencies
+        mock_matlab_agent, _ , mock_load_config, _  = mock_dependencies
 
         mock_load_config.return_value = {
             'agent': {'agent_id': 'custom_agent'},
@@ -129,7 +129,7 @@ def test_main_with_config_file(self, cli_runner, mock_dependencies):
     def test_main_without_config_file_exists(
             self, cli_runner, mock_dependencies, default_config):
         """Test main function when config.yaml exists in current directory."""
-        mock_matlab_agent, mock_setup_logger, mock_load_config, mock_logger = mock_dependencies
+        mock_matlab_agent, _, mock_load_config, _ = mock_dependencies
 
         with patch('pathlib.Path.exists', return_value=True):
             mock_load_config.return_value = default_config
@@ -261,7 +261,7 @@ def test_generate_default_config_success_importlib(self):
         with patch('pathlib.Path.cwd', return_value=test_dir), \
                 patch('pathlib.Path.exists', return_value=False), \
                 patch('importlib.resources.files') as mock_files, \
-                patch('builtins.open', mock_open()) as mock_file:
+                patch('builtins.open', mock_open()) as _:
 
             # Mock importlib.resources.files behavior
             mock_resource = MagicMock()
@@ -297,7 +297,7 @@ def test_generate_default_config_fallback_pkg_resources(self):
                 patch('pathlib.Path.exists', return_value=False), \
                 patch('importlib.resources.files', side_effect=ImportError()), \
                 patch.dict('sys.modules', {'pkg_resources': mock_pkg_resources}), \
-                patch('builtins.open', mock_open()) as mock_file, \
+                patch('builtins.open', mock_open()) as _, \
                 patch('builtins.print') as mock_print:
 
             generate_default_config()
@@ -368,7 +368,7 @@ def test_generate_config_with_attribute_error_fallback(self):
                 patch('pathlib.Path.exists', return_value=False), \
                 patch('importlib.resources.files', side_effect=AttributeError()), \
                 patch.dict('sys.modules', {'pkg_resources': mock_pkg_resources}), \
-                patch('builtins.open', mock_open()) as mock_file, \
+                patch('builtins.open', mock_open()) as _, \
                 patch('builtins.print') as mock_print:
 
             generate_default_config()
@@ -381,7 +381,7 @@ def test_generate_default_project_success_importlib(self):
         """Test successful project generation using importlib.resources."""
         with patch('pathlib.Path.exists', return_value=False), \
                 patch('importlib.resources.files') as mock_files, \
-                patch('builtins.open', mock_open()) as mock_file, \
+                patch('builtins.open', mock_open()) as _, \
                 patch('builtins.print') as mock_print:
 
             # Mock importlib.resources.files behavior
@@ -506,7 +506,7 @@ def test_cli_help_option(self, cli_runner):
 
     def test_cli_short_config_option(self, cli_runner, mock_dependencies):
         """Test short form of config option (-c)."""
-        mock_matlab_agent, mock_setup_logger, mock_load_config, mock_logger = mock_dependencies
+        _, _, mock_load_config, _ = mock_dependencies
 
         mock_load_config.return_value = {
             'agent': {'agent_id': 'test_agent'},
@@ -534,7 +534,7 @@ def test_multiple_flags_priority(self, cli_runner):
 
     def test_broker_type_hardcoded(self, cli_runner, mock_dependencies):
         """Test that broker_type is hardcoded to 'rabbitmq'."""
-        mock_matlab_agent, mock_setup_logger, mock_load_config, mock_logger = mock_dependencies
+        mock_matlab_agent, _, mock_load_config, _ = mock_dependencies
 
         mock_load_config.return_value = {
             'agent': {'agent_id': 'test_agent'},

agents/matlab/matlab_agent/test/unit/test_rabbitmq_manager.py

@@ -94,6 +94,8 @@ def test_initialization(self, mock_connection, mock_config, agent_id):
 
     def test_register_message_handler(self, rabbitmq_manager):
         def handler(channel, method, properties, body):
+            """ Dummy handler for testing. """
+            # This function is intentionally left empty to serve as a placeholder for testing.
             pass
         rabbitmq_manager.register_message_handler(handler)
         assert rabbitmq_manager.message_handler is handler

agents/matlab/matlab_agent/test/unit/test_streaming.py

@@ -1,7 +1,7 @@
 """Test suite for streaming functionality."""
 
-# pylint: disable=missing-module-docstring, missing-class-docstring,
-# missing-function-docstring, too-many-positional-arguments
+
+# pylint: disable=too-many-positional-arguments
 
 
 import socket
@@ -373,7 +373,7 @@ def test_handle_streaming_simulation_missing_fields(
         {'simulation': {'foo': 'bar'}},  # Missing data
         'test_queue',
         mock_rabbit_client,
-        None,  # path_simulation not specified
+        Path("test_path"),
         response_templates,
         tcp_settings
     )