Skip to content

Commit 1db221f

Browse files
committed
update the SVD algorithm
1 parent 4fabb55 commit 1db221f

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

lkauto/algorithms/svd.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
from lenskit.algorithms import svd
2-
from ConfigSpace import Integer, Float, ConfigurationSpace
1+
from lenskit.sklearn.svd import BiasedSVDScorer
2+
from ConfigSpace import ConfigurationSpace, UniformIntegerHyperparameter, UniformFloatHyperparameter
33

44

5-
class BiasedSVD(svd.BiasedSVD):
5+
class BiasedSVD(BiasedSVDScorer):
66
def __init__(self, features, **kwargs):
77
super().__init__(features=features, **kwargs)
88

@@ -19,12 +19,13 @@ def get_default_configspace(number_item: int, **kwargs):
1919
"""
2020
n_items = number_item
2121
if n_items < 10000:
22-
features = Integer('features', bounds=(2, n_items), default=n_items-1, log=True) # No default values given
22+
features = UniformIntegerHyperparameter('features', lower=2, upper=n_items, default_value=n_items-1, log=True)
2323
else:
24-
features = Integer('features', bounds=(2, 10000), default=1000, log=True) # No default values given
25-
damping = Float('damping', bounds=(0.0001, 1000), default=5.0, log=True)
24+
#features = Integer('features', bounds=(2, 10000), default=1000, log=True) # No default values given
25+
features = UniformIntegerHyperparameter('features', lower=2, upper=10000, log=True)
26+
damping = UniformFloatHyperparameter('damping', lower=0.0001, upper=1000, log=True)
2627

2728
cs = ConfigurationSpace()
28-
cs.add_hyperparameters([features, damping])
29+
cs.add([features, damping])
2930

3031
return cs

0 commit comments

Comments
 (0)