made the parameter feature accessible for testing, added the default value for damping + Test for svd is now OK

Author: EinfachAnass

lkauto/algorithms/svd.py

@@ -5,6 +5,7 @@
 class BiasedSVD(BiasedSVDScorer):
     def __init__(self, features, **kwargs):
         super().__init__(features=features, **kwargs)
+        self.features = features  # Store features as an instance variable for testing 
 
     @staticmethod
     def get_default_configspace(number_item: int, **kwargs):
@@ -22,8 +23,8 @@ def get_default_configspace(number_item: int, **kwargs):
             features = UniformIntegerHyperparameter('features', lower=2, upper=n_items, default_value=n_items-1, log=True)
         else:
             #features = Integer('features', bounds=(2, 10000), default=1000, log=True)  # No default values given
-            features = UniformIntegerHyperparameter('features', lower=2, upper=10000, log=True)
-        damping = UniformFloatHyperparameter('damping', lower=0.0001, upper=1000, log=True)
+            features = UniformIntegerHyperparameter('features', lower=2, upper=10000, default_value=1000, log=True)
+        damping = UniformFloatHyperparameter('damping', lower=0.0001, upper=1000, default_value=5, log=True)
 
         cs = ConfigurationSpace()
         cs.add([features, damping])

tests/algorithms/test_svd.py

@@ -7,16 +7,16 @@
 
 class TestSVD(unittest.TestCase):
     def test_init_givenObjectInitialized_ObjectInitializedCorrectlyExpected(self):
-        features = 10
-        svd = BiasedSVD(features)
-        self.assertIsInstance(svd, BiasedSVD)
-        self.assertEqual(features, svd.factorization.n_components)
+        expected_features = 10
+        biased_svd = BiasedSVD(expected_features)
+        self.assertIsInstance(biased_svd, BiasedSVD)
+        self.assertEqual(expected_features, biased_svd.features)
 
     def test_defaultConfigspace_GivenFunctionCalled_correctConfigSpaceReturnedExpected(self):
         number_item_list = [1500, 100000]
         for number_item in number_item_list:
             cs = BiasedSVD.get_default_configspace(number_item=number_item)
-            params = cs.get_hyperparameters()
+            params = list(cs.values())
             with self.subTest(number_item=number_item):
                 self.assertIsInstance(cs, CS.ConfigurationSpace)
                 if number_item < 10000: