Skip to content

Commit e943137

Browse files
author
Max
committed
Update lkauto.py
Tests at least run, but a lot of deprecation warning + some tests fail
1 parent 5665cc7 commit e943137

File tree

1 file changed

+19
-17
lines changed

1 file changed

+19
-17
lines changed

lkauto/lkauto.py

Lines changed: 19 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,26 +3,28 @@
33

44
from ConfigSpace import ConfigurationSpace
55

6-
from lkauto.utils.get_model_from_cs import get_model_from_cs
7-
from lkauto.optimization_strategies.bayesian_optimization import bayesian_optimization
8-
from lkauto.optimization_strategies.random_search import random_search
9-
from lkauto.utils.filer import Filer
10-
from lkauto.ensemble.ensemble_builder import build_ensemble
11-
from lkauto.preprocessing.preprocessing import preprocess_data
12-
from lkauto.utils.logging import get_logger
13-
14-
from lenskit.metrics.predict import rmse
15-
from lenskit.metrics.topn import ndcg
16-
from lenskit.algorithms import Predictor
17-
from lenskit import Recommender
6+
from utils.get_model_from_cs import get_model_from_cs
7+
from optimization_strategies.bayesian_optimization import bayesian_optimization
8+
from optimization_strategies.random_search import random_search
9+
from utils.filer import Filer
10+
from ensemble.ensemble_builder import build_ensemble
11+
from preprocessing.preprocessing import preprocess_data
12+
from utils.logging import get_logger
13+
14+
from lenskit.metrics import RMSE
15+
from lenskit.metrics import NDCG
16+
from lenskit.pipeline import Component
17+
18+
# from lenskit.algorithms import Predictor
19+
# from lenskit import Recommender
1820

1921
from typing import Tuple
2022

2123

2224
def get_best_prediction_model(train: pd.DataFrame,
2325
validation: pd.DataFrame = None,
2426
cs: ConfigurationSpace = None,
25-
optimization_metric=rmse,
27+
optimization_metric=RMSE,
2628
optimization_strategie: str = 'bayesian',
2729
time_limit_in_sec: int = 2700,
2830
num_evaluations: int = 500,
@@ -42,7 +44,7 @@ def get_best_prediction_model(train: pd.DataFrame,
4244
timestamp_col: str = 'timestamp',
4345
include_timestamp: bool = True,
4446
log_level: str = 'INFO',
45-
filer: Filer = None) -> Tuple[Predictor, dict]:
47+
filer: Filer = None) -> Tuple[Component, dict]:
4648
"""
4749
returns the best Predictor found in the defined search time
4850
@@ -211,7 +213,7 @@ def get_best_prediction_model(train: pd.DataFrame,
211213
else:
212214
# build model from best model configuration found by SMAC
213215
model = get_model_from_cs(incumbent, feedback='explicit')
214-
incumbent = incumbent.get_dictionary()
216+
incumbent = dict(incumbent)
215217
logger.info('--Best Model--')
216218
logger.info(incumbent)
217219

@@ -224,7 +226,7 @@ def get_best_prediction_model(train: pd.DataFrame,
224226
def get_best_recommender_model(train: pd.DataFrame,
225227
validation: pd.DataFrame = None,
226228
cs: ConfigurationSpace = None,
227-
optimization_metric=ndcg,
229+
optimization_metric=NDCG,
228230
optimization_strategie: str = 'bayesian',
229231
time_limit_in_sec: int = 2700,
230232
num_evaluations: int = 500,
@@ -244,7 +246,7 @@ def get_best_recommender_model(train: pd.DataFrame,
244246
timestamp_col: str = 'timestamp',
245247
include_timestamp: bool = True,
246248
log_level: str = 'INFO',
247-
filer: Filer = None) -> Tuple[Recommender, dict]:
249+
filer: Filer = None) -> Tuple[Component, dict]:
248250
"""
249251
returns the best Recommender found in the defined search time
250252

0 commit comments

Comments
 (0)