Merge pull request #956 from thewtex/output-indexing

thewtex · web-flow · commit 9ceab72bced5 · 2023-09-26T18:08:31.000-04:00
fix(bindgen): only skip output index for files with node
diff --git a/src/bindgen/typescript/function-module.js b/src/bindgen/typescript/function-module.js
@@ -323,7 +323,7 @@ function functionModule (srcOutputDir, forNode, interfaceJson, modulePascalCase,
         }
       }
       functionContent += '\n'
-      if (!interfaceType.includes('File')) {
+      if (!(forNode && interfaceType.includes('File'))) {
         outputCount++
       }
     } else {
@@ -460,7 +460,7 @@ function functionModule (srcOutputDir, forNode, interfaceJson, modulePascalCase,
         functionContent += `    ${camel}: outputs[${outputIndex}].data as ${interfaceType},\n`
       }
     }
-    if (!interfaceType.includes('File')) {
+    if (!(forNode && interfaceType.includes('File'))) {
       outputCount++
     }
   })

Original file line number	Diff line number	Diff line change
`@@ -323,7 +323,7 @@ function functionModule (srcOutputDir, forNode, interfaceJson, modulePascalCase,`
`323`	`323`	`}`
`324`	`324`	`}`
`325`	`325`	`functionContent += '\n'`
`326`		`- if (!interfaceType.includes('File')) {`
	`326`	`+ if (!(forNode && interfaceType.includes('File'))) {`
`327`	`327`	`outputCount++`
`328`	`328`	`}`
`329`	`329`	`} else {`
`@@ -460,7 +460,7 @@ function functionModule (srcOutputDir, forNode, interfaceJson, modulePascalCase,`
`460`	`460`	functionContent += ` ${camel}: outputs[${outputIndex}].data as ${interfaceType},\n`
`461`	`461`	`}`
`462`	`462`	`}`
`463`		`- if (!interfaceType.includes('File')) {`
	`463`	`+ if (!(forNode && interfaceType.includes('File'))) {`
`464`	`464`	`outputCount++`
`465`	`465`	`}`
`466`	`466`	`})`