Skip to content

Commit 09e5ce0

Browse files
committed
refactor
1 parent 889caa4 commit 09e5ce0

File tree

3 files changed

+6
-24
lines changed

3 files changed

+6
-24
lines changed

gui/editor/editorwidget.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ EditorWidget::EditorWidget(QWidget *parent) : QWidget(parent) {
167167
connect(this, &EditorWidget::frameChanged, reprojectionWidget, &ReprojectionWidget::calculateReprojectionSlot);
168168
connect(this, &EditorWidget::frameChanged, datasetControlWidget, &DatasetControlWidget::frameChangedSlot);
169169
connect(this, &EditorWidget::cmdRPressed, keypointWidget, &KeypointWidget::toggleCurrentKeypointSlot);
170-
connect(this, &EditorWidget::cmdEPressed, keypointWidget, &KeypointWidget::skipCurrentKeypointSlot);
170+
connect(this, &EditorWidget::cmdEPressed, keypointWidget, &KeypointWidget::advanceCurrentKeypointSlot);
171171

172172
//<-> Relayed Signals
173173
connect(datasetControlWidget, &DatasetControlWidget::datasetLoaded, this, &EditorWidget::newSegmentLoaded);

gui/editor/keypointwidget.cpp

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,7 @@ void KeypointWidget::init() {
7373
connect(bodyPartsListWidget, &KeypointListWidget::removeKeypoint, this, &KeypointWidget::removeKeypointSlot);
7474
connect(bodyPartsListWidget, &KeypointListWidget::suppressKeypoint, this, &KeypointWidget::suppressKeypointSlot);
7575
connect(bodyPartsListWidget, &KeypointListWidget::unsuppressKeypoint, this, &KeypointWidget::unsuppressKeypointSlot);
76-
// connect(bodyPartsListWidget, &KeypointListWidget::toggleCurrentKeypoint, this, &KeypointWidget::toggleCurrentKeypointSlot);
77-
connect(bodyPartsListWidget, &KeypointListWidget::afterToggleSuppression, this, &KeypointWidget::afterToggleSuppressionSlot);
76+
connect(bodyPartsListWidget, &KeypointListWidget::advanceCurrentKeypoint, this, &KeypointWidget::advanceCurrentKeypointSlot);
7877

7978
for (const auto& bp : Dataset::dataset->bodypartsList()) {
8079
QListWidgetItem * bpItem = new QListWidgetItem();
@@ -183,23 +182,7 @@ void KeypointWidget::toggleCurrentKeypointSlot() {
183182
keypointList->toggleCurrentKeypointSuppression();
184183
}
185184

186-
void KeypointWidget::afterToggleSuppressionSlot() {
187-
188-
KeypointListWidget* keypointList = keypointListMap[m_currentEntity];
189-
190-
// advance the row to the next keypoint, if possible
191-
if (keypointList->currentRow() < keypointList->count()-1) {
192-
keypointList->setCurrentRow(keypointList->currentRow()+1);
193-
194-
// update the viewer accordingly
195-
QColor color = colorMap->getColor(keypointList->currentRow(), keypointList->count());
196-
m_currentBodypart = keypointList->item(keypointList->currentRow())->text();
197-
emit currentBodypartChanged(m_currentBodypart, color);
198-
emit updateViewer();
199-
}
200-
}
201-
202-
void KeypointWidget::skipCurrentKeypointSlot(){
185+
void KeypointWidget::advanceCurrentKeypointSlot(){
203186
// figure out which keypointList is currently active
204187
KeypointListWidget* keypointList = keypointListMap[m_currentEntity];
205188

gui/editor/keypointwidget.hpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,14 +55,14 @@ class KeypointListWidget : public QListWidget {
5555
m_suppressedList.append(current);
5656
emit suppressKeypoint(current);
5757
}
58-
emit afterToggleSuppression();
58+
emit advanceCurrentKeypoint();
5959
}
6060

6161
signals:
6262
void removeKeypoint(int row);
6363
void suppressKeypoint(int row);
6464
void unsuppressKeypoint(int row);
65-
void afterToggleSuppression();
65+
void advanceCurrentKeypoint();
6666

6767
private:
6868
QList<int> m_suppressedList = {};
@@ -150,8 +150,7 @@ class KeypointWidget : public QWidget {
150150
void frameChangedSlot(int currentImgSetIndex, int currentFrameIndex);
151151
void setKeypointsFromDatasetSlot();
152152
void toggleCurrentKeypointSlot();
153-
void afterToggleSuppressionSlot();
154-
void skipCurrentKeypointSlot();
153+
void advanceCurrentKeypointSlot();
155154

156155
private:
157156
ColorMap *colorMap;

0 commit comments

Comments
 (0)