Skip to content

Commit 9c14931

Browse files
committed
Detect OpenGL errors ignored by the core before popping debug scopes
- Otherwise an exception would be thrown from `__exit__`
1 parent 7ded904 commit 9c14931

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/libretro/drivers/video/opengl/moderngl.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,7 @@ def get_proc_address(self, sym: bytes) -> int | None:
345345
def refresh(
346346
self, data: memoryview | FrameBufferSpecial, width: int, height: int, pitch: int
347347
) -> None:
348-
_clear_gl_errors()
348+
_warn_unhandled_gl_errors()
349349

350350
with self._context.debug_scope("libretro.ModernGlVideoDriver.refresh"):
351351
match data:
@@ -416,8 +416,7 @@ def reinit(self) -> None:
416416
"libretro.ModernGlVideoDriver.reinit.context_destroy"
417417
):
418418
self._callback.context_destroy()
419-
420-
_warn_unhandled_gl_errors()
419+
_warn_unhandled_gl_errors()
421420

422421
if self._window:
423422
self._window.destroy()
@@ -530,8 +529,7 @@ def reinit(self) -> None:
530529
"libretro.ModernGlVideoDriver.reinit.context_reset"
531530
):
532531
self._callback.context_reset()
533-
534-
_warn_unhandled_gl_errors()
532+
_warn_unhandled_gl_errors()
535533

536534
@override
537535
@property

0 commit comments

Comments
 (0)